fix issue #18 #22
Merged
fix issue #18 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2016 21:49
| (from element in priorityGroup | ||
| orderby GetCenterCoordinate(element) ascending | ||
| select element).ToList() | ||
| where orderedElements.Count >= 2 |
There was a problem hiding this comment.
this where right here seems to be the source of the bug. if all of the groups have just one item (which seems to be a timing issue, at least for me) , then all of the groups get filtered out here, and the min throws because there are no elements.
also considered adding an extension method like MinOrDefault(0) that would return a default value if a sequence was empty.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimum distance calculation expects every group to have at least 2 items, and fails with a "Sequence contains no elements" when this expectation is not met
i have no idea why the diff is showing every line is changed. i only changed refactored starting at 507, extracting that section of linq to the method GetMinimumDistanceBetweenItems at the bottom that could handle the case when a group contains one or no elements.