final polishes?

yaacovCR · Oct 18, 2024 · 6c2cde6 · 6c2cde6
1 parent 44cce56
commit 6c2cde6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/src/execution/values.ts b/src/execution/values.ts
@@ -245,7 +245,8 @@ export function experimentalGetArgumentValues(
         ? fragmentVariableValues
         : variableValues;
       if (
-        scopedVariableValues?.coerced[variableName] === undefined &&
+        (scopedVariableValues == null ||
+          !Object.hasOwn(scopedVariableValues.coerced, variableName)) &&
         !isRequiredArgument(argDef)
       ) {
         if (argDef.defaultValue) {

diff --git a/src/utilities/coerceInputValue.ts b/src/utilities/coerceInputValue.ts
@@ -272,7 +272,7 @@ export function coerceInputLiteral(
 
   const leafType = assertLeafType(type);
   try {
-    return leafType.coerceInputLiteral !== undefined
+    return leafType.coerceInputLiteral
       ? leafType.coerceInputLiteral(
           replaceVariables(valueNode, variableValues, fragmentVariableValues),
         )

diff --git a/src/utilities/validateInputValue.ts b/src/utilities/validateInputValue.ts
@@ -455,13 +455,9 @@ function validateInputLiteralImpl(
     let result;
     let caughtError;
     try {
-      result =
-        type.coerceInputLiteral !== undefined
-          ? type.coerceInputLiteral(
-              replaceVariables(valueNode),
-              hideSuggestions,
-            )
-          : type.parseLiteral(valueNode, undefined, hideSuggestions);
+      result = type.coerceInputLiteral
+        ? type.coerceInputLiteral(replaceVariables(valueNode), hideSuggestions)
+        : type.parseLiteral(valueNode, undefined, hideSuggestions);
     } catch (error) {
       if (error instanceof GraphQLError) {
         context.onError(error, pathToArray(path));