Further Puma 6 fix and fix for #26

[ollym]

logger by default is events which doesn't work in Puma 6, it fails with: undefined method log' for #Puma::Events:0x00007f905c558720`

[ollym]

@Envek let me know if this is ok

[Envek]

But it should be overriden with correct value in create_server here:

yabeda-puma-plugin/lib/puma/plugin/yabeda_prometheus.rb

Line 43 in 0408a48

logger = server.respond_to?(:log_writer) ? server.log_writer : events

So, most probably you should get undefined method 'log' for nil instead. Or am I missing something?

[ollym]

@Envek the value of logger before my PR defaults to events so if on_stopped fired before create_server then we're calling events.log which since Puma 6 was removed. This is the issue we're running into in production.

The other issue described in #26 is only possible because unless server&.shutting_down? does not guard if server is null, and if that's the case server.stop(true) will fail with undefined method 'stop' for nil.

Adjusting it to if server && !server.shutting_down? guards against server being null, which also guards against that block being called before create_server is called, so logger.log is guaranteed to work also.

Hope that makes more sense.

[Envek]

Makes total sense! Thank you!

Released in 0.7.1