Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure in Chrome 51 #1114

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Fix test failure in Chrome 51 #1114

merged 1 commit into from
Jun 6, 2016

Conversation

nmielnik
Copy link
Member

@nmielnik nmielnik commented Jun 6, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? changed
License MIT

Description

Now in Chrome 51, NodeList objects have defined a forEach method. There was a test that attempted to confirm that forEach wasn't defined on a NodeList to ensure that code that had depended on forEach was safely executing.

I've updated the test to assert that the NodeList is not an Array instead.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.969% when pulling 4a7c46e on chrome-test-fix into d496a1c on master.

@nmielnik nmielnik merged commit 3cf797e into master Jun 6, 2016
@j0k3r j0k3r deleted the chrome-test-fix branch June 6, 2016 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants