Make linkValidation allow hash links #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| link = editor.elements[0].querySelector('a'); | ||
| expect(link).not.toBeNull(); | ||
| expect(link.getAttribute('href')).toBe(validHashLink); | ||
| }); |
There was a problem hiding this comment.
Could you add an extra space before and after this assertion?
There was a problem hiding this comment.
Good point, I will add spaces.
| @@ -235,7 +235,8 @@ | |||
| // Matches any alphabetical characters followed by :// | |||
| // Matches protocol relative "//" | |||
| // Matches common external protocols "mailto:" "tel:" "maps:" | |||
| var urlSchemeRegex = /^([a-z]+:)?\/\/|^(mailto|tel|maps):/i, | |||
| // Matches relative hash link, "#" followed by any character | |||
| var urlSchemeRegex = /^([a-z]+:)?\/\/|^(mailto|tel|maps):|^\#.+/i, | |||
There was a problem hiding this comment.
Should this allow just plain # as a valid link? Right now it seems like it wouldn't allow that.
There was a problem hiding this comment.
In my opinion, the hash should be omitted if there is no fragment identifier; however, you are correct that it is valid, so it should be allowed here.
|
Looks awesome @cruzanmo , thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows hash links, e.g.
#fragment-identifier, whenlinkValidationis set totrue. This was brought up in this discussion: #714