task4 #6
task4 #6
Conversation
UI/script.js
Outdated
| return result; | ||
| } | ||
|
|
||
| function filterHashtag(photoPosts, hashtag) { |
There was a problem hiding this comment.
UI/script.js
Outdated
| } | ||
|
|
||
| function getPhotoPost(id) { | ||
| for (var item in photoPosts) { |
There was a problem hiding this comment.
UI/script.js
Outdated
| return result; | ||
| } | ||
|
|
||
| function getPhotoPosts(skip, top, filterConfig) { |
UI/script.js
Outdated
| if (filterConfig === undefined) { | ||
| return photoPosts.sort(compareDate).slice(skip, skip + top); | ||
| } else { | ||
| resultArray = photoPosts.sort(compareDate).slice(skip, skip + top); |
There was a problem hiding this comment.
что-то мне подсказывает, что это надо делать после фильтров
UI/script.js
Outdated
| || photoPost.hashTag.length === 0 || photoPost.like.length === 0) { | ||
| return false; | ||
| } | ||
| for (var item in photoPost.hashTag) { |
There was a problem hiding this comment.
смотри, это как минимум не item а index
for .. in впринципе лучше не использовать
есть обычный for, forEach, for .. of
UI/script.js
Outdated
| } | ||
|
|
||
| function editPhotoPost(id, objectPhotoPost) { | ||
| if (validatePhotoPost(objectPhotoPost)) { |
There was a problem hiding this comment.
я могу ошибаться, но что-то мне подсказывает что это плохая идея т.к не все поля обязательны
UI/script.js
Outdated
| if (!objectPhotoPost) { | ||
| return false; | ||
| } | ||
| if (id === undefined) { |
UI/script.js
Outdated
| removePhotoPost('4'); | ||
| editPhotoPost('1', {hashTag: ['#hashtag_1', '#hashtag_8']}); | ||
| getPhotoPost('1'); | ||
| } |
UI/script.js
Outdated
| return false; | ||
| } | ||
|
|
||
| console.log(getPhotoPosts(0, 10)); |
| if (!objectPhotoPost) { | ||
| return false; | ||
| } | ||
| if (id === undefined || typeof id !== 'string') { |
There was a problem hiding this comment.
typeof id !== 'string' этого будет достаточно
UI/index.html
Outdated
| <link rel="stylesheet" href="style.css"> | ||
| </head> | ||
| <body> | ||
| <script src="script.js"></script> |
There was a problem hiding this comment.
Не внимательно слушала Яну на лекции:
Типичная ошибка №1:
См внимательно: https://learn.javascript.ru/external-script
UI/script.js
Outdated
| }]; | ||
|
|
||
| function compareDate(a, b) { | ||
| return (a.createdAt) - (b.createdAt); |
There was a problem hiding this comment.
откуда опять копипастим чужие неточности ? (вопрос риторический, я уже видел откуда)
Скобки не нужны.
UI/script.js
Outdated
| return (a.createdAt) - (b.createdAt); | ||
| } | ||
|
|
||
| function filterAuthor(photoPosts, author) { |
There was a problem hiding this comment.
почему findByAuthor называется (дословно "отфильтровать авторов")
UI/script.js
Outdated
| } | ||
|
|
||
| function filterAuthor(photoPosts, author) { | ||
| var result = []; |
UI/script.js
Outdated
| return result; | ||
| } | ||
|
|
||
| function filterHashtag(photoPosts, hashtag) { |
UI/script.js
Outdated
| return true; | ||
| } | ||
| function removePhotoPost(id) { | ||
| for (var i in photoPosts) { |
There was a problem hiding this comment.
https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex
и будут всего 3 понятные строчки...
| return false; | ||
| } | ||
|
|
||
| function editPhotoPost(id, objectPhotoPost) { |
There was a problem hiding this comment.
Логика не соответствует той которая прописана в задании.
UI/script.js
Outdated
| like: ['author21'] | ||
| }); | ||
| removePhotoPost('4'); | ||
| editPhotoPost('1', {hashTag: ['#hashtag_1', '#hashtag_8']}); |
UI/index.html
Outdated
| </div> | ||
| </div> | ||
| <!--2photo--> | ||
| <div class="photo_post" id="2"> |
There was a problem hiding this comment.
id="2"
не не не
это о другом не связываем прямвот так
Если прям гарантируем что на страничке пост всегда будет рисоваться только в одном месте то можно но с суфиксом: id="post-item-{id}"
А лучше помечать data аттрибутами
data-id="2"
UI/index.html
Outdated
| <div class="image_name_date"><img class="post_image" src="images/103.png"/> | ||
| <p class="name_date"><b>Murashko Yuliya</b><br>06.03.2018</p> | ||
| </div> | ||
| <div class="delete_redact"> |
There was a problem hiding this comment.
redact ... ??
edit :)
Но даже с edit, название класса не айс.
No description provided.