Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executers instead of Threads #142

Closed
sanastas opened this issue Mar 2, 2021 · 1 comment
Closed

Executers instead of Threads #142

sanastas opened this issue Mar 2, 2021 · 1 comment
Labels
HackTogether

Comments

@sanastas
Copy link
Contributor

sanastas commented Mar 2, 2021 •
edited
Loading

Change all tests to use Executers instead of Threads. In order to propagate raised exceptions to the tests. Currently we might miss some exceptions.

@liran-funaro can you please add more details to this issue?

For more explanations feel free to add questions in this issue.
@OrHayat OrHayat mentioned this issue Mar 21, 2021
Merged
liran-funaro pushed a commit that referenced this issue Mar 30, 2021
@OrHayat
Changed tests thread array into executor and added timeout and except…
2a2ff5f 
…ion handling (#149)

* changed some tests thread array list into executor and added timeout and exception handling like asked in issue #142
* changed some tests thread array list into executor and added timeout and exception handling like asked in issue #142
* removed static from countdown latch and executor service in FillTest
* changed some runnable to callables to allow exceptions to propagate
* import test
* import fix
* changed constants to final
* added finally block to close the executors in any case
* reformat code
* removed excess whitespace
* removed currentTime initialization
* reformat code
* try {
* reformat code
* added a comment on task.get()
@sanastas
Copy link
Contributor Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HackTogether
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sanastas