ENH: ignore unsatified operations with partial inputs #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankostis
force-pushed
the
enh-ignore_unsatified
branch
from
8c45c22
to
5563067
Compare
ankostis
added a commit
to ankostis/graphtik
that referenced
this pull request
Sep 29, 2019
Usefull when 2 (or more) operations provifing the same output, and only one has fully satisfied inputs. Before it would fail trying to evaluate the un-satisfied ones. + New TC added. .
ankostis
added a commit
to ankostis/graphtik
that referenced
this pull request
Sep 29, 2019
Usefull when 2 (or more) operations provifing the same output, and only one has fully satisfied inputs. Before it would fail trying to evaluate the un-satisfied ones. + New TC added. .
ankostis
force-pushed
the
enh-ignore_unsatified
branch
from
5563067
to
1519baa
Compare
ankostis
added a commit
to ankostis/graphtik
that referenced
this pull request
Sep 29, 2019
Usefull when 2 (or more) operations provifing the same output, and only one has fully satisfied inputs. Before it would fail trying to evaluate the un-satisfied ones. + New TC added. .
ankostis
force-pushed
the
enh-ignore_unsatified
branch
from
1519baa
to
16be1cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 77.87% 79.01% +1.14%
==========================================
Files 5 5
Lines 348 367 +19
==========================================
+ Hits 271 290 +19
Misses 77 77
Continue to review full report at Codecov.
|
were writing in text-mode in PY3. and failing as encoding error.
ankostis
added a commit
to ankostis/graphtik
that referenced
this pull request
Sep 30, 2019
+ The x2 TCs added just before are now passing.
ankostis
force-pushed
the
enh-ignore_unsatified
branch
from
16be1cd
to
1967995
Compare
receiving partial inputs, needed for other operations.
+ The x2 TCs added just before are now passing.
ankostis
force-pushed
the
enh-ignore_unsatified
branch
2 times, most recently
from
10c1d7f
to
66e0a8c
Compare
NOTE dict are not deterministic in <PY3.6. So this commit would not improve determinism in those pythons. + build: add `boltons` dependency for ndexedSet. + doc: mark all set usage if affect determinism. + e.g. see reproducibility problem in yahoo#14.
ankostis
force-pushed
the
enh-ignore_unsatified
branch
from
66e0a8c
to
b8377ca
Compare
|
Merged with #23 bc ordered-set is needed to rewrite unsatisfied traversal with topo-sort (without visited nodes). |
ankostis
force-pushed
the
enh-ignore_unsatified
branch
from
a6d5533
to
e578042
Compare
ankostis
force-pushed
the
enh-ignore_unsatified
branch
from
e578042
to
b102d44
Compare
This was referenced Oct 2, 2019
... backported from yahoo#29.
ankostis
referenced
this pull request
in syamajala/graphkit
Oct 8, 2019
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
The purpose is not to require a "perfect" input model for the dag to run,
but the algorithm to find the minimum viable subgraph that can compute.
Useful also when 2 (or more) operations provide the same output,
and provided inputs fully satisfy only one of operation.
Changes
For instance, the graph below with this PR can go ahead and compute
ab_plus_c=21when given justa=10&b1=2, andab_plus_c=6when given justa=10&b2=2:Before this PR, the above graph would fail on execution time while trying to evaluate needlesly
the un-satisfied operations.
NOTE that it is an invasive change and have repercussions to many decision of this library.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.