Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX(#13, plot): PY2 era BUG when writing plot-diagrams; give sample code in the into #19

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

FIX(#13, plot): PY2 era BUG when writing plot-diagrams; give sample code in the into #19

wants to merge 34 commits into from

Commits on Sep 28, 2019

  1. FIX(build): py2 needs pinning networkx-2.2

    @ankostis
    ankostis committed Sep 28, 2019
    Configuration menu
    Copy the full SHA
    617e577 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2019

  1. FIX(yahoo#13): BUG in plot-diagram writtin from PY2 era, 

    were writing in text-mode in PY3. and failing as encoding error.
    @ankostis
    ankostis committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    f58d148 View commit details
    Browse the repository at this point in the history

  2. doc(yahoo#13): sample code to plot workflow diagram in intro

    @ankostis
    ankostis committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    c75a2c0 View commit details
    Browse the repository at this point in the history

  3. enh(plot): provide help msg on supported file-exts

    @ankostis
    ankostis committed Sep 29, 2019
    Configuration menu
    Copy the full SHA
    a005bd6 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2019

  1. enh(build): replace numpy with pytest... 

    numpy was used just for its assert_raise
    @ankostis
    ankostis committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    32409f6 View commit details
    Browse the repository at this point in the history

  2. feat(build): add pip-extras [test]

    @ankostis
    ankostis committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    f606ed1 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2019

  1. TEST(plot,ci): test plotting; pip install extras in Travis

    @ankostis
    ankostis committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    cd1370b View commit details
    Browse the repository at this point in the history

  2. fix(plot): don't create file on unsupported formats 

    thanks to @andres-fr.
    @ankostis
    ankostis committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    f676662 View commit details
    Browse the repository at this point in the history

  3. enh(plot.TC): expose supported writers and TC on them

    @ankostis
    ankostis committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    65d1816 View commit details
    Browse the repository at this point in the history

  4. enh(build,ci): use pytest in travis

    @ankostis
    ankostis committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    4e55b30 View commit details
    Browse the repository at this point in the history

  5. fix(plot): NetOp did not return pydot instance

    @ankostis
    ankostis committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    47b50f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. refact(plot): extract plot function out of Network class... 

    to use it also on stary DAGs.  Keep delegation.
    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    b1d02a1 View commit details
    Browse the repository at this point in the history

  2. fix(plot): matplotlib plot was failing in PY3 due IO io misuse

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    c11af2a View commit details
    Browse the repository at this point in the history

  3. FEAT(plot): overlay Execution STEPS on diagrams

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    344490b View commit details
    Browse the repository at this point in the history

  4. ENH(plot): +inputs, +outputs, +solution modify plotting 

    (see yahoo#13 for an example):
    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    23ef81e View commit details
    Browse the repository at this point in the history

  5. refact(plot.TC): move plot tests to early beggining

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    4e8601c View commit details
    Browse the repository at this point in the history

  6. doc(plot): tell supported formats in doctest, +TC

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    834a8b0 View commit details
    Browse the repository at this point in the history

  7. doc(plot): add legend & example; docstring in netop.plot()

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    c2e28a4 View commit details
    Browse the repository at this point in the history

  8. enh(plot): mark optional "needs"

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    e38c8ad View commit details
    Browse the repository at this point in the history

  9. ENH(plot): visual enhamcents on nodes & edges

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    d855bf6 View commit details
    Browse the repository at this point in the history

  10. test(plot): enhance plot test to try all yahoo#13 features; 

    + test all chained plot() methods from netop.
    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    ca5d243 View commit details
    Browse the repository at this point in the history

  11. doc(plot); explain also params in user-facing API

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    a2de9ef View commit details
    Browse the repository at this point in the history

  12. FIX(PLOT.TC): TC was always testing PNG, ... 

    + retorfitted to try all available formats.
+ list of forbidden formats based on my failres
    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    dc5a21a View commit details
    Browse the repository at this point in the history

  13. fix(plot): don't require Matplotlib if no Window asked

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    782d9b9 View commit details
    Browse the repository at this point in the history

  14. test(plot): check also matplotlib show=True

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    7d389c3 View commit details
    Browse the repository at this point in the history

  15. ENH(plot): return SVG rendered in JUPYTER, ... 

    + doc: rename in sample code: netop --> pipeline.
+ enh(build): add `ipython` in test dependencies.
+ include it in the plot TC.
    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    3fe0b40 View commit details
    Browse the repository at this point in the history

  16. refact(plot.TC): avoid writting multiple temp-files

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    1471551 View commit details
    Browse the repository at this point in the history

  17. MERGE PYTEST into PLOT to parametrize TCs.

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    af7ae0f View commit details
    Browse the repository at this point in the history

  18. fix(build): reuse dependencies definitions

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    b440196 View commit details
    Browse the repository at this point in the history

  19. REFACT(plot.TC): PYTESTize and parametrize

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    bde9b64 View commit details
    Browse the repository at this point in the history

  20. REFACT(PLOT): MOVE PLOT in own module

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    8e361e6 View commit details
    Browse the repository at this point in the history

  21. DROP PY3.4 - add PY3.6, PY3.7... 

    ...pytest has problems with 3.4.
    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    b08a363 View commit details
    Browse the repository at this point in the history

  22. refact(plot): separate graphviz building from IO

    @ankostis
    ankostis committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    3a87959 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. FIX(plot): failing if steps not a list/ is none... 

    backported from yahoo#29
    @ankostis
    ankostis committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    4aca013 View commit details
    Browse the repository at this point in the history