Fixed some type mistakes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dw-kihara
commented
May 30, 2024
|
Hi! Goot catch, thanks! Like with #57, could you please add the review comment to the commit message? |
|
I stopped the test against Erlang 23. You can rebase your branch on top of the latest master and CI should be happy. |
dw-kihara
force-pushed
the
fix/type_mistakes
branch
from
91e346f to
56fab69
Compare
- proplist:proplist() -> proplists:proplist() - map:map() -> map() - avoid an undefined record element
dw-kihara
force-pushed
the
fix/type_mistakes
branch
from
56fab69 to
c22a8e7
Compare
Added the summary for the change. |
|
I merged your pull request, thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dialyzer found some type mistakes.