Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #99 related to ListTileTheme #101

Merged
merged 4 commits into from
Jan 9, 2022

Conversation

zeusbaba
Copy link
Contributor

@zeusbaba zeusbaba commented Dec 6, 2021

fix issue #99 related to ListTileTheme

@tomarra
Copy link

tomarra commented Dec 10, 2021

Now that Flutter 2.8 is released to stable would be great to get this merged and released :)

@cirediew cirediew mentioned this pull request Dec 13, 2021
@felix-ht
Copy link

felix-ht commented Dec 13, 2021

you probably should add

environment:
  flutter: ^2.8.0

to pubspec as this will not work with old versions of flutter

@zeusbaba
Copy link
Contributor Author

you probably should add

environment:
  flutter: ^2.8.0

to pubspec as this will not work with old versions of flutter

done

@zhelon
Copy link

zhelon commented Dec 14, 2021

can you merge and release it soon?

@zeusbaba
Copy link
Contributor Author

while waiting for this be merged, you can use my fork;

settings_ui:
    git: git://github.com/beerstorm-net/flutter-settings-ui.git  

@rteitge
Copy link

rteitge commented Dec 14, 2021

@zeusbaba your fork is based on dart sdk 2.8 without null safety so not usable.

@zeusbaba
Copy link
Contributor Author

@zeusbaba your fork is based on dart sdk 2.8 without null safety so not usable.

see why it done so #101 (comment)

@zeusbaba
Copy link
Contributor Author

@zeusbaba your fork is based on dart sdk 2.8 without null safety so not usable.

see why it done so #101 (comment)

you are right, I just reverted this to null safety.

@felix-ht
Copy link

@zeusbaba you have to add flutter: ^2.8.0 as a new line under environment and not as part of sdk.

https://dart.dev/tools/pub/pubspec#sdk-constraints at the very bottom of the page

@fredecodes
Copy link

FYI there is already a fork of this project which has an associated pub.dev package here:
https://pub.dev/packages/flutter_settings_ui

My understanding is that the original creator of this package (yak-dev) has gone awol and is not updating the pub.dev package or merging pull requests, so one of the contributors created this fork and new package. I will be using it going forward.

@elirehema
Copy link

Thanks @fredecodes it works

Copy link

@thecertifiednoob thecertifiednoob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

come on merge it! we are facing issue in new version of flutter

@yadaniyil
Copy link
Contributor

Hey everyone. Sorry for not reviewing this PR for such a long time. The new 2.0.0 version is just published where the code is rewritten from scratch, bugs are fixed and new features and UI were added. Please check if the new version contains your bug fix and create a new PR if it's not. This package is not forgotten, alive, new features will be added and PRs will be checked in time. Thanks.

@yadaniyil yadaniyil closed this Jan 9, 2022
@yadaniyil yadaniyil reopened this Jan 9, 2022
@yadaniyil yadaniyil merged commit 84bf848 into yako-dev:master Jan 9, 2022
@yadaniyil
Copy link
Contributor

Merged, thanks @zeusbaba.

To use the package with this fix use in pubspec.yaml:

settings_ui:
    git: git://github.com/yako-dev/flutter-settings-ui.git  

Also, consider moving to the new 2.0.0 version that will be maintained from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants