-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue #99 related to ListTileTheme
#101
Conversation
Now that Flutter 2.8 is released to stable would be great to get this merged and released :) |
you probably should add environment:
flutter: ^2.8.0 to pubspec as this will not work with old versions of flutter |
done |
can you merge and release it soon? |
while waiting for this be merged, you can use my fork;
|
@zeusbaba your fork is based on dart sdk 2.8 without null safety so not usable. |
see why it done so #101 (comment) |
you are right, I just reverted this to null safety. |
@zeusbaba you have to add https://dart.dev/tools/pub/pubspec#sdk-constraints at the very bottom of the page |
FYI there is already a fork of this project which has an associated pub.dev package here: My understanding is that the original creator of this package (yak-dev) has gone awol and is not updating the pub.dev package or merging pull requests, so one of the contributors created this fork and new package. I will be using it going forward. |
Thanks @fredecodes it works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
come on merge it! we are facing issue in new version of flutter
Hey everyone. Sorry for not reviewing this PR for such a long time. The new 2.0.0 version is just published where the code is rewritten from scratch, bugs are fixed and new features and UI were added. Please check if the new version contains your bug fix and create a new PR if it's not. This package is not forgotten, alive, new features will be added and PRs will be checked in time. Thanks. |
Merged, thanks @zeusbaba. To use the package with this fix use in pubspec.yaml:
Also, consider moving to the new 2.0.0 version that will be maintained from now. |
fix issue #99 related to
ListTileTheme