Fix printer installation for non-utop toplevels #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that adding `(modules Integer_printers)` to the dune file broke non-utop toplevels, resulting in the printers not getting registered. Inlining the printers in the installation module (in the style of ctypes-top) seems to fix the issue.
brendanzab
force-pushed
the
fix-printer-installation
branch
from
8482eb2 to
b38b455
Compare
|
I’ve noticed that printers are not installed for |
|
Argh, well it seems like the API I was trying to use to detect |
yallop
force-pushed
the
fix-printer-installation
branch
from
e41d68b to
866ae74
Compare
|
Thank you for the fix, @brendanzab! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #52 (comment), it seems that #52 actually broke printing for non-utop toplevels. Inlining the functions into the module (as is done in
ctypes.top), along with preloading the dependencies fixes it for both toplevels, and retains consistent formatting between them.As an alternative to this PR, #52 could be reverted instead, and we could just live with utop being broken for now.