Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ahash crate to fix build #46

Closed
wants to merge 5 commits into from

Conversation

clems4ever
Copy link
Contributor

@clems4ever clems4ever commented Nov 18, 2024

currently, cargo build generates the following error due to the removal of stdsim: rust-lang/rust#117372

error[E0635]: unknown feature stdsimd
--> /home/cmichaud/.cargo/registry/src/index.crates.io-6f17d22bba15001f/ahash-0.8.3/src/lib.rs:99:42
|
99 | #![cfg_attr(feature = "stdsimd", feature(stdsimd))]

Also fixed two errors reported by clippy and ran cargo fmt that updated around 40 files.

@clems4ever
Copy link
Contributor Author

the workflow is green in my fork after those changes.

@clems4ever clems4ever force-pushed the ahash-bump branch 2 times, most recently from 285d885 to fc695e0 Compare November 18, 2024 22:09
currently, cargo build generates the following error due to the removal
of stdsim: rust-lang/rust#117372
@clems4ever
Copy link
Contributor Author

sorry for the commits mess, I was trying to fix my GPG signature. I'm done.

@clems4ever
Copy link
Contributor Author

it seems that int tests are broken on windows.

@clems4ever
Copy link
Contributor Author

well, it seemed to be a randomness due to the use of rayon. I just disabled it for the get_hyperedges_intersections function to fix the issue.

@yamafaktory
Copy link
Owner

well, it seemed to be a randomness due to the use of rayon. I just disabled it for the get_hyperedges_intersections function to fix the issue.

Actually this was a bug :) - thanks for tackling it!

@clems4ever clems4ever closed this Nov 19, 2024
yamafaktory added a commit that referenced this pull request Nov 19, 2024
* bump ahash crate to fix build

currently, cargo build generates the following error due to the removal
of stdsim: rust-lang/rust#117372

* fix clippy errors

* attempt to fix formatting

* attempt to not parallelize he intersection

* remove rayon prelude

* chore(cargo): update dependencies and modernize crate

* chore(cargo): update lock via cargo update

---------

Co-authored-by: Clément Michaud <clement.michaud34@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants