WIP: Another safe_load API attempt #198
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress.
safe_load
will be as safe as beforeload(..., Loader=LoaderClass)
The point behind renaming to Python* was, that in the future we could split up the PythonLoader class into a safe and a less safe one.
The current one will load arbitrary modules and will call any method/function.
I had the idea to make a safer version of that by only allowing creating instances of already loaded classes, and not calling methods. This is what I would expect a serializer to do.
I'm not sure yet if this is completely safe in Python, though. (In Perl it's not, because some objects can run code when they are garbage collected, so you can construct an exploit if you find a module that does something dangerous in its garbage collection handler.)
Then the less safer class could be named PythonCodeLoader or something like that.
Comments welcome