Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a problem building in release modes #62

Closed
wants to merge 4 commits into from

Conversation

richardgroves
Copy link
Contributor

The version 5.0.0 wont build in release mode -see #59 - this PR fixes that by updating some iOS deployment versions: from 8.0 to 11.0.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #62 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   93.24%   93.31%   +0.06%     
==========================================
  Files          14       14              
  Lines         385      314      -71     
==========================================
- Hits          359      293      -66     
+ Misses         26       21       -5     
Flag Coverage Δ
#ios 93.31% <ø> (+0.06%) ⬆️
#osx 7.00% <ø> (+1.03%) ⬆️
Impacted Files Coverage Δ
Sources/HSL.swift 100.00% <0.00%> (ø)
Sources/Utils.swift 100.00% <0.00%> (ø)
Sources/DynamicColor.swift 100.00% <0.00%> (ø)
Sources/SwiftUIColor.swift 0.00% <0.00%> (ø)
Sources/DynamicGradient.swift 100.00% <0.00%> (ø)
Sources/DynamicColor+HSB.swift 100.00% <0.00%> (ø)
Sources/DynamicColor+HSL.swift 100.00% <0.00%> (ø)
Sources/DynamicColor+Lab.swift 100.00% <0.00%> (ø)
Sources/DynamicColor+XYZ.swift 100.00% <0.00%> (ø)
Sources/DynamicColor+RGBA.swift 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31383de...983f6e5. Read the comment docs.

@richardgroves
Copy link
Contributor Author

Not fully working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant