Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for latest NodeJS v20 #11

Merged
merged 13 commits into from
Dec 4, 2023
Merged

feat: support for latest NodeJS v20 #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2f2e5ee
Enforce scripts running on bash.
glektarssza Dec 2, 2023
411fe61
First go at NodeJS v20 support.
glektarssza Dec 2, 2023
d1afb73
Update tests with NodeJS v20 checks.
glektarssza Dec 2, 2023
a44d260
Used NodeJS v21 modules version instead of v20.
glektarssza Dec 2, 2023
0d21c2a
Use v8 flags the right way.
glektarssza Dec 2, 2023
debeefe
Fixed an unfortunate typo.
glektarssza Dec 2, 2023
9e11583
Fixed another typo.
glektarssza Dec 2, 2023
ce5feb6
Fixed missing pkg bootstrapper.
glektarssza Dec 2, 2023
1fe757b
Fixed another typo.
glektarssza Dec 2, 2023
4d783bc
Fixed yet another typo.
glektarssza Dec 2, 2023
16aee35
Trying to fix sourceless arg.
glektarssza Dec 2, 2023
2b6ffee
I cannot type apparently.
glektarssza Dec 2, 2023
40e79e3
Update all builds to also target NodeJS v20.
glektarssza Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-alpine.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 19]
target-node: [14, 16, 18, 19, 20]
target-arch: [x64, arm64]
include:
- target-arch: x64
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 19]
target-node: [14, 16, 18, 19, 20]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-linuxstatic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 19]
target-node: [14, 16, 18, 19, 20]
target-arch: [x64, arm64, armv7]
include:
- target-arch: x64
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 19]
target-node: [14, 16, 18, 19, 20]

steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target-node: [14, 16, 18, 19]
target-node: [14, 16, 18, 19, 20]
target-arch: [x64, arm64]

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false # prevent test to stop if one fails
matrix:
node-version: [12, 14, 16, 18, 19] # match patched node versions
node-version: [12, 14, 16, 18, 19, 20] # match patched node versions
os: [ubuntu-latest] # Skip macos-latest, windows-latest for now

runs-on: ${{ matrix.os }}
Expand Down
5 changes: 5 additions & 0 deletions lib/verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ const script = `
} else
if (modules === 111) {
// no cpu features anymore
} else
if (modules === 115) {
// no cpu features anymore
} else {
assert(false, modules);
}
Expand Down Expand Up @@ -91,6 +94,8 @@ const script = `
if (modules === 108) {
} else
if (modules === 111) {
} else
if (modules === 115) {
} else {
assert(false, modules);
}
Expand Down
Loading