Make modal-dialog component animatable via liquid-fire #193
+969
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- To animate non-tethered cases, install `liquid-wormhole` and pass `animatable=true` - To animate tethered cases, install `liquid-tether` and pass `animatable=true` - See the dummy app for examples - Note that in 3.0.0, the animatable code path will be used automatically if these libraries are present and `animatable` is unspecified. To prepare users for this, a deprecation warning is emitted if the libraries are present and `animatable` is unspecified in 2.x. - targetAttachment of "center" and "middle center" now uses SCSS for positioning rather than dynamic rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
liquid-wormholeand passanimatable=trueliquid-tetherand passanimatable=trueanimatableis unspecified. To prepare users for this, a deprecation warning is emitted if the libraries are present andanimatableis unspecified in 2.x.