Guard against document being undefined.
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to adding this guard, any applications using fastboot would throw an error on application boot (because `document` is `undefined` in Node). The modal dialog behavior in this addon will likely not work, but the application should boot.
lukemelia
added a commit
that referenced
this pull request
May 11, 2015
Guard against `document` being undefined.
|
Thanks. In the future, it would be nice to figure out how to at least recover properly upon rehydration. |
|
I think that if you avoided Unfortunately, I do not believe that the DOMHelper instance that is setup with the simple-dom instance, is public (it is available via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to adding this guard, any applications using fastboot would throw an error on application boot (because
documentisundefinedin Node).The modal dialog behavior in this addon will likely not work, but the application should boot.