assert that specified alignment target exists #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +31,9 @@ export default Ember.Component.extend({ | |||
| updateAlignment: function() { | |||
| var alignmentTarget = this.get('alignmentTarget'); | |||
| if (Ember.typeOf(alignmentTarget) === 'string') { | |||
| let alignmentTargetSelector = alignmentTarget; | |||
| alignmentTarget = Ember.$(alignmentTarget)[0]; | |||
There was a problem hiding this comment.
Can we use alignmentTargetSelector on the right hand side of this line to make this function more readable?
raycohen
added a commit
that referenced
this pull request
Aug 3, 2015
assert that specified alignment target exists
|
Thanks @kagemusha! |
|
@lukemelia No prob. Thanks for the add-on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If alignmentTarget selector doesn't specify an existing element, almost certain to cause an error further down (e.g. call on undefined originOffset). This assert points out the source of the problem.