Create separate modal-dialog and tether-dialog components #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrislopresto
commented
Sep 6, 2015
chrislopresto
commented
- Extract tether functionality into separate tether-dialog component
- Use nested structure in modal-dialog component to support various scrolling/overlay use cases @sandstrom
- Add example where scrolling the overlay scrolls the modal content @samselikoff @sandstrom
- Unify target and attachment terminology with that of Hubspot Tether
- Remove a bunch of normalization logic that had been providing backwards compatibility for usage patterns prior to the introduction of ember-tether
chrislopresto
force-pushed
the
restructuring
branch
from
b66d237
to
68718c9
Compare
|
|
||
| Pros and cons of each approach are detailed below. | ||
| - modal-dialog: Uses ember-wormhole to append the following nested divs to the destination element: wrapper div > overlay div > container div | ||
| - tether-dialog: Uses ember-tether to display modal container div. Uses ember-wormhole to append optional overlay div to the destination element. Requires separate installation of [ember-tether](//github.com/yapplabs/ember-tether) dependency. |
There was a problem hiding this comment.
A diagram would speak 1000 words here
chrislopresto
force-pushed
the
restructuring
branch
2 times, most recently
from
e946a7a
to
940df5e
Compare
- Extract tether functionality into separate tether-dialog component - Use nested structure in modal-dialog component to support various scrolling/overlay use cases @sandstrom - Add example where scrolling the overlay scrolls the modal content @samselikoff @sandstrom - Unify target and attachment terminology with that of Hubspot Tether - Remove a bunch of normalization logic that had been providing backwards compatibility for usage patterns prior to the introduction of ember-tether - Add visual diagrams. Update README. - Remove hasOverlay from modal-dialog component
chrislopresto
force-pushed
the
restructuring
branch
from
940df5e
to
56bfdf3
Compare
lukemelia
added a commit
that referenced
this pull request
Sep 10, 2015
Create separate modal-dialog and tether-dialog components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.