Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift, YDB 2.7, YapDatabaseLoggingTechniqueDisabled and Foundation problem #195

Closed
onfoot opened this issue Jul 20, 2015 · 2 comments
Closed

Comments

@onfoot
Copy link

onfoot commented Jul 20, 2015

Hi,
if I disable logging for YapDatabase, a compile error is emitted in YapDatabaseLogging.h file because of an unknown type NSString. Adding importing Foundation to that file helps, though I'm not sure if that's a correct solution, since I'm not that familiar with YapDatabase's codebase and would like to be able to use straight 2.7 branch, without my local uncommitted modifications, which causes Xcode Server builds fail.

Could you please add the line to the 2.7 branch. I can of course submit a pull request, if that makes things easier.

@robbiehanson
Copy link
Contributor

Thanks for the report. Should be fixed now. Let me know if you encounter any other problems.

@onfoot
Copy link
Author

onfoot commented Jul 21, 2015

Great, exactly what I needed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants