[YAP-244]: Adds nullable attribute to properties consistently. #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbiehanson
added a commit
that referenced
this pull request
Nov 11, 2015
…_to_property_which_defaults_nil [YAP-244]: Adds nullable attribute to properties consistently.
Consistency is appreciated. I'll keep this ordering in mind. |
|
👍 |
|
@robbiehanson is there any chance that recent changes which fix build issues in Carthage & the missing nullable attributes can be released as 2.7.5? |
|
v2.7.5 has been tagged & pushed. |
|
Thanks @robbiehanson |
|
@robbiehanson would you also be able to push it to CocoaPods? Thanks! |
|
Oh - sorry - weird |
|
Heads-up. I had to push v2.7.6 because of issue #245 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were more
nullableattributes missing from properties which should be optionals. Also, I've edited existingnullableattributes so that they're added to the list of property attributes so that nullable is added consistently at the end.