Support for updating an AutoView's sorting block without updating it's grouping block #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #222
Resolves #286
Adds
setSorting:versionTag:
toYapDatabaseAutoViewTransaction
, which allows you to update the sorting block without the overhead of re-grouping all records in the view.High points:
I don't like the first half of the
resortView
method where it gathers the row ids. It shouldn't be a problem for most data sets, but loading all rowIds into memory, each boxed in an NSNumber doesn't feel good at all. This should be refactored to use a data structure with a predictable memory footprint, but I wanted to get something working first to make sure I wasn't missing any larger concepts.The two
_handleChangeWithRowid:...
methods can also probably be refactored a bit to share some code. Again, want to make sure I haven't missed something important first.