Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "fab" Neoden YY1 #565

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Add "fab" Neoden YY1 #565

merged 6 commits into from
Aug 17, 2023

Conversation

cubesky
Copy link
Contributor

@cubesky cubesky commented Jul 7, 2023

This is a "fab" command for Desktop Pick and Place machine Neodan YY1.

It will create Top and Bottom Layer Position file in Neodan YY1 format.

@yaqwsx
Copy link
Owner

yaqwsx commented Jul 7, 2023

I believe you didn't commit all the files.

@cubesky
Copy link
Contributor Author

cubesky commented Jul 7, 2023

I believe you didn't commit all the files.

Sorry, I forget doing git add

@cubesky cubesky changed the title Add "fab" NeodanYY1 Add "fab" Neoden YY1 Jul 7, 2023
Copy link
Owner

@yaqwsx yaqwsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I highlighted some aspects of the code to improve. Could you reflect it?

kikit/fab/neodenyy1.py Outdated Show resolved Hide resolved
kikit/fab/neodenyy1.py Outdated Show resolved Hide resolved
kikit/fab_ui.py Outdated Show resolved Hide resolved
kikit/fab_ui.py Outdated Show resolved Hide resolved
kikit/fab_ui.py Outdated Show resolved Hide resolved
kikit/fab/neodenyy1.py Outdated Show resolved Hide resolved
kikit/fab/neodenyy1.py Outdated Show resolved Hide resolved
kikit/fab/neodenyy1.py Show resolved Hide resolved
kikit/fab/neodenyy1.py Show resolved Hide resolved
@cubesky
Copy link
Contributor Author

cubesky commented Jul 8, 2023

Resolved.

@cubesky cubesky requested a review from yaqwsx July 8, 2023 14:30
@cubesky
Copy link
Contributor Author

cubesky commented Jul 21, 2023

Hello, is there any update for this?

@yaqwsx
Copy link
Owner

yaqwsx commented Aug 17, 2023

Looks much better! Merging, thank you.

@yaqwsx yaqwsx merged commit 63301c2 into yaqwsx:master Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants