chore: export Y18N class #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atlslscsrv-app
approved these changes
Jul 7, 2021
There was a problem hiding this comment.
Approved
signed of by Laura Vanlaningham
dopry:chore/exportY18N.diff
(stayloveable@outlook.com)
|
@bcoe who should I contact about reviewing and merging this PR? |
bcoe
approved these changes
Aug 13, 2021
|
@dopry thanks for the patch, I will do my best to land soon. |
|
@bcoe hey do you need me to rebase this or anything? I'm still running on a fork and would really like to get back on upstream. |
|
@dopry my bad, I lost track of this. It looks like this potentialy breaks the ESM exports unfortunately, any ideas? |
allows users to explicitly construct their Y18N instance with their own choice of shim.
dopry
force-pushed
the
chore/exportY18N
branch
from
6c76ee0
to
6ec4924
Compare
|
It looks like I needed to leave out the opts interface in the CJS file. JS doesn't understand interfaces. It should pass now. |
bcoe
reviewed
Nov 17, 2021
bcoe
approved these changes
Nov 17, 2021
|
not off hand. I'm busy on other projects for the foreseeable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows users to explicitly construct their Y18N instance with their
own choice of shim.