Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: Incorrect type display when nodelinker is PNP #3058

Closed
1 task
joker77877 opened this issue Jun 29, 2021 · 3 comments · Fixed by #3297
Closed
1 task

[Bug?]: Incorrect type display when nodelinker is PNP #3058

joker77877 opened this issue Jun 29, 2021 · 3 comments · Fixed by #3297
Assignees
Labels
bug Something isn't working upholded Real issues without formal reproduction

Comments

@joker77877
Copy link

Self-service

  • I'd be willing to implement a fix

Describe the bug

The find type of lodash es displays an error when nodelinker is PNP,but when nodelinker is node modules, the type is displayed correctly.

To reproduce

This is wrong.
image
image

This is right.
image
image

Environment

System:
OS: macOS 10.15.6
CPU: (8) x64 Intel(R) Core(TM) i5-8257U CPU @ 1.40GHz
Binaries:
Node: 12.19.0 - /private/var/folders/cl/v57320pd1l1f8ldjtj8j7_5r0000gn/T/xfs-5af90304/node
Yarn: 2.4.2 - /private/var/folders/cl/v57320pd1l1f8ldjtj8j7_5r0000gn/T/xfs-5af90304/yarn
npm: 6.14.8 - /usr/local/bin/npm

Additional context

No response

@joker77877 joker77877 added the bug Something isn't working label Jun 29, 2021
@merceyz
Copy link
Member

merceyz commented Jul 2, 2021

Unable to reproduce, please provide an actual reproduction as your "To reproduce" info is basically just showing the end result, not how to get there

@merceyz merceyz added the waiting for feedback Will autoclose in a while unless more data are provided label Jul 2, 2021
@joker77877
Copy link
Author

https://github.com/joker77877/vue-vite-volar
path: src/main.ts
image

@yarnbot
Copy link
Collaborator

yarnbot commented Aug 15, 2021

Hi! 👋

This issue looks stale, and doesn't feature the reproducible label - which implies that you didn't provide a working reproduction using Sherlock. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it or you edit your first post to include a formal reproduction (you can use the playground for that).

Note that we require Sherlock reproductions for long-lived issues (rather than standalone git repositories or similar) because we're a small team. Sherlock gives us the ability to check which bugs are still affecting the master branch at any given point, and decreases the amount of code we need to run on our own machines (thus leading to faster bug resolutions). It helps us help you! 😃

If you absolutely cannot reproduce a bug on Sherlock (for example because it's a Windows-only issue), a maintainer will have to manually add the upholded label. Thanks for helping us triaging our repository! 🌟

@yarnbot yarnbot added the stale Issues that didn't get attention label Aug 15, 2021
@merceyz merceyz added upholded Real issues without formal reproduction and removed waiting for feedback Will autoclose in a while unless more data are provided labels Aug 15, 2021
@yarnbot yarnbot removed the stale Issues that didn't get attention label Aug 15, 2021
@merceyz merceyz self-assigned this Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upholded Real issues without formal reproduction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants