-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug?]: pnp-esm.test.ts fails on node 22 #6267
Labels
bug
Something isn't working
Comments
@arcanis @merceyz @paul-soporan @larixer you are the contact in citgm :) |
Similar issue for other package might give some ideas: |
Thanks for the heads up, though would have expected these to fail before v22 was released. EDIT: They did nodejs/node#52505 (comment). |
3 tasks
arcanis
pushed a commit
that referenced
this issue
May 6, 2024
**What's the problem this PR addresses?** In Node.js v22 import assertions were replaced with import attributes so we need to add support for those as well. Fixes #6267 **How did you fix it?** Added support for the `importAttributes` property. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
merceyz
added a commit
that referenced
this issue
May 8, 2024
**What's the problem this PR addresses?** In Node.js v22 import assertions were replaced with import attributes so we need to add support for those as well. Fixes #6267 **How did you fix it?** Added support for the `importAttributes` property. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm wondering if it's node issue or yarn
Self-service
Describe the bug
Seem like the test
packages/acceptance-tests/pkg-tests-specs/sources/pnp-esm.test.ts
is failing on node 22To reproduce
run the test in node 22
Environment
System: OS: Linux 6.2 Ubuntu 20.04.6 LTS (Focal Fossa) CPU: (2) x64 AMD EPYC 7763 64-Core Processor Binaries: Node: 22.0.0 - /tmp/xfs-f68ecfb2/node Yarn: 4.2.1-dev - /tmp/xfs-f68ecfb2/yarn npm: 10.5.1 - ~/nvm/current/bin/npm
Additional context
The text was updated successfully, but these errors were encountered: