feat(pnp): support the --conditions flag
#5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
added a commit
that referenced
this pull request
Jan 31, 2023
* feat(pnp): support the `--conditions` flag * test: check `NODE_OPTIONS` works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Node.js allows users to customise the conditions used when resolving
exportsandimportsbut PnP doesn't.https://nodejs.org/dist/latest-v18.x/docs/api/cli.html#-ccondition---conditionscondition
Fixes #5171
Ref #2431
Ref nodejs/node#36935
How did you fix it?
Adapted the CLI parsing from https://github.com/TypeStrong/ts-node to add support for custom conditions.
Checklist