-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compat): update patch for typescript@5.5.0-beta
#6248
Conversation
3d7ae22
to
d58ffb4
Compare
Fixes #6250 |
Hello @merceyz I tried in the past to apply similar patches for new versions of TS, but I don't exactly know what are the steps to go from microsoft/TypeScript#35206 to the fixes in the yarn repo. |
would love to use 5.5-beta as well :) |
@Ayc0 I create a new branch based on the upstream release branch and cherry-pick the commits from the last time I updated the patch and fix any conflicts that may show up. |
**What's the problem this PR addresses?** The SDK changes in #6248 broke support for older TypeScript versions. I tested it on `5.4.1-rc` (master) and it was fine but it crashes on 5.2.0-beta (https://github.com/yarnpkg/berry/blob/4308dca8091438e8f88682e59ef5ba5bc72241ca/package.json#L26) **How did you fix it?** Check the TypeScript version and only apply the patch if needed. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
**What's the problem this PR addresses?** The PnP compatibility patch for TypeScript doesn't apply to `typescript@5.5.0-beta`. Ref microsoft/TypeScript#35206 **How did you fix it?** Rebased it. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
**What's the problem this PR addresses?** The SDK changes in #6248 broke support for older TypeScript versions. I tested it on `5.4.1-rc` (master) and it was fine but it crashes on 5.2.0-beta (https://github.com/yarnpkg/berry/blob/4308dca8091438e8f88682e59ef5ba5bc72241ca/package.json#L26) **How did you fix it?** Check the TypeScript version and only apply the patch if needed. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
I feel there is the same issue with 5.6-rc this time 🤔 |
There's a draft PR: #6461 |
What's the problem this PR addresses?
The PnP compatibility patch for TypeScript doesn't apply to
typescript@5.5.0-beta
.Ref microsoft/TypeScript#35206
How did you fix it?
Rebased it.
Checklist