-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor tweaks to website #6264
Minor tweaks to website #6264
Conversation
I bumped the client bundle ES version based on the original browserslist config (which was not used). On second thought, let's not introduce a potentially breaking change in this PR.
tsconfig.json
Outdated
"target": "ES2022", | ||
"lib": ["ES2023"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression that the ES bump isn't because that's what TypeScript recommends for Node 18 and is supported by node.green. Turns out, they are both wrong.
Removing the DOM lib should be safe though? It was added in #4851, most likely because create-docusaurus
was run on the root instead of under the docusaurus workspace.
Oh and I forgot to mention, regarding the dependencies, there are a few that I don't know what to do with them
For this PR I'm not touching them since there is no harm but I'm generally all for removing unnecessary deps. Also, in theory, all the default plugins are dependencies of the docusaurus workspace because they are needed to generate the CLI docs. So, in theory we should list all of them as dependencies. This would have the benefit that (together with this PR) that the website can be built with a production-only focused docusaurus workspace but I'm not sure if the maintainence burden is worth that. Side quesetion: Why is the website built with |
I don't remember a particular reason 🤔 |
What's the problem this PR addresses?
Some minor/nitpick-level problems with the website
Note: This PR has some overlap with #6218. I'll rebase one when the other is merged
How did you fix it?
create-docusaurus
docusaurus.config.ts
itself) to aconfig
directory. May not seem like much but as more stuff gets added this can keep thing clean and manageable.yarn build
successfully is a dep and devDeps are those that are purely for DX (e.g. types)Checklist