Enhance ESLint config

.yarn/versions/a712705e.yml

@@ -0,0 +1,2 @@
+releases:
+  "@yarnpkg/eslint-config": minor

eslint.config.mjs

@@ -3,44 +3,61 @@ import eslintConfig      from '@yarnpkg/eslint-config';
 
 // eslint-disable-next-line arca/no-default-export
 export default [
-  ...eslintConfig,
-  ...reactEslintConfig,
-
   {
     ignores: [
-      `*.json`,
       `**/coverage/**`,
+      `**/__snapshots__/**`,
       `.yarn`,
+      `.pnp.cjs`,
+      `.pnp.loader.mjs`,
 
-      `packages/docusaurus/.docusaurus`,
-
-      `packages/yarnpkg-pnp/sources/hook.js`,
-      `packages/yarnpkg-pnp/sources/esm-loader/built-loader.js`,
+      // Pre-compiled binaries
+      `packages/*/lib`,
+      `packages/*/bin`,
+      `packages/*/build`,
+      `packages/*/bundles`,
 
-      `packages/yarnpkg-libzip/sources/libzipAsync.js`,
-      `packages/yarnpkg-libzip/sources/libzipSync.js`,
+      // Test fixtures
+      `packages/**/*fixtures*`,
 
-      // The parsers are auto-generated
-      `packages/yarnpkg-parsers/sources/grammars/*.js`,
+      // Generated files for website
+      `packages/docusaurus/.docusaurus`,
 
+      // Generated compressed worker
       `packages/yarnpkg-core/sources/worker-zip/index.js`,
-      `packages/yarnpkg-cli/bundles/yarn.js`,
 
-      `packages/*/lib`,
-      `packages/*/bin`,
-      `packages/*/build`,
-      `packages/**/*fixtures*`,
+      // Build output for libui
+      `packages/yarnpkg-libui/sources/**/*.js`,
+      `packages/yarnpkg-libui/sources/**/*.d.ts`,
+
+      // Pre-compiled from C sources
+      `packages/yarnpkg-libzip/sources/libzipAsync.js`,
+      `packages/yarnpkg-libzip/sources/libzipSync.js`,
+      // The C sources themselves
       `packages/yarnpkg-libzip/artifacts`,
-      `packages/plugin-compat/extra/fsevents/fsevents-*.js`,
 
-      // Minimize the diff with upstream`,
+      // Generated compressed hooks
+      `packages/yarnpkg-pnp/sources/hook.js`,
+      `packages/yarnpkg-pnp/sources/esm-loader/built-loader.js`,
+      // Minimize the diff with upstream
       `packages/yarnpkg-pnp/sources/node`,
       `packages/yarnpkg-pnp/sources/loader/node-options*`,
+
+      // Generated PEG.js grammars
+      `packages/yarnpkg-parsers/sources/grammars/*.js`,
+
+      // Patched fsevents
+      `packages/plugin-compat/extra/fsevents/fsevents-*.js`,
     ],
   },
 
+  ...eslintConfig,
+  ...reactEslintConfig,
+
   {
-    files: [`!packages/*/sources/{index,Plugin}.ts`],
+    name: `berry/naming-convention`,
+    files: [`**/*.ts`, `**/*.cts`, `**/*.mts`, `**/*.tsx`],
+    ignores: [`packages/*/sources/{index,Plugin}.ts`],
     rules: {
       '@typescript-eslint/naming-convention': [`error`, {
         selector: `typeLike`,
@@ -54,6 +71,7 @@ export default [
   },
 
   {
+    name: `berry/env/acceptance-tests`,
     files: [`packages/acceptance-tests/pkg-tests-specs/**/*.test.{js,ts}`],
     languageOptions: {
       globals: {
@@ -64,6 +82,7 @@ export default [
   },
 
   {
+    name: `berry/rules`,
     rules: {
       'no-restricted-properties': [2,
         {

package.json

@@ -7,6 +7,7 @@
   ],
   "devDependencies": {
     "@arcanis/sherlock": "^2.0.3",
+    "@eslint/config-inspector": "^0.5.0",
     "@types/jest": "^28.1.6",
     "@types/micromatch": "^4.0.1",
     "@types/node": "^18.17.15",
@@ -54,7 +55,7 @@
     "build:plugin-workspace-tools": "yarn node -r ./scripts/setup-ts-execution ./scripts/create-mock-plugin.ts workspace-tools",
     "build:plugin-commands": "node ./scripts/gen-plugin-commands.js > packages/yarnpkg-cli/sources/pluginCommands.ts",
     "build:compile": "rm -rf \"$0\"/lib && mkdir -p \"$0\"/lib && rsync -a --include '*.d.ts' --exclude '*.ts' --exclude '*.tsx' \"$0\"/sources/ \"$0\"/lib/ && node scripts/compile \"$@\"",
-    "test:lint": "eslint --max-warnings 0 \"./**/*.@(tsx|ts|js|mjs)\"",
+    "test:lint": "eslint --max-warnings 0 .",
     "test:unit": "jest",
     "typecheck:all": "tsc -p ."
   },

packages/eslint-config/index.js

@@ -8,28 +8,35 @@ import typescript    from './rules/typescript.js';
 
 // eslint-disable-next-line arca/no-default-export
 export default [
-  ...bestPractices,
-  ...errors,
-  ...style,
-  ...typescript,
-
   {
+    name: `@yarnpkg/setup`,
     languageOptions: {
       parser: tsParser,
       sourceType: `module`,
+    },
+  },
+  {
+    name: `@yarnpkg/env`,
+    languageOptions: {
       globals: {
         ...globals.node,
         ...globals.es2021,
       },
     },
   },
-
   {
+    name: `@yarnpkg/env/tests`,
     files: [`**/*.test.*`],
+    ignores: [`**/__snapshots__/**`],
     languageOptions: {
       globals: {
         ...globals.jest,
       },
     },
   },
+
+  ...bestPractices,
+  ...errors,
+  ...style,
+  ...typescript,
 ];

packages/eslint-config/rules/best-practices.js

@@ -4,6 +4,8 @@ import arcaEslint       from 'eslint-plugin-arca';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
+    name: `@yarnpkg/configs/best-practices`,
+
     plugins: {
       [`arca`]: arcaEslint,
       [`@typescript-eslint`]: typescriptEslint,

packages/eslint-config/rules/errors.js

@@ -4,6 +4,8 @@ import arcaEslint       from 'eslint-plugin-arca';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
+    name: `@yarnpkg/configs/errors`,
+
     plugins: {
       [`arca`]: arcaEslint,
       [`@typescript-eslint`]: typescriptEslint,
@@ -73,10 +75,4 @@ export default [
       'valid-typeof': 2,
     },
   },
-  {
-    files: [`*.test.{js,ts}`],
-    env: {
-      jest: true,
-    },
-  },
 ];

packages/eslint-config/rules/react.js

@@ -4,6 +4,8 @@ import reactEslint from 'eslint-plugin-react';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
+    name: `@yarnpkg/configs/react`,
+
     plugins: {
       [`arca`]: arcaEslint,
       [`react`]: reactEslint,

packages/eslint-config/rules/style.js

@@ -4,6 +4,8 @@ import arcaEslint       from 'eslint-plugin-arca';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
+    name: `@yarnpkg/configs/style`,
+
     plugins: {
       [`arca`]: arcaEslint,
       [`@typescript-eslint`]: typescriptEslint,
@@ -22,16 +24,6 @@ export default [
 
       '@typescript-eslint/comma-spacing': 2,
 
-      '@typescript-eslint/naming-convention': [`error`, {
-        selector: `default`,
-        format: [`camelCase`, `UPPER_CASE`, `PascalCase`],
-        filter: {
-          regex: `^(__.*|__non_webpack_require__|npm(_[a-z]+)+)$`,
-          match: false,
-        },
-        leadingUnderscore: `allow`,
-      }],
-
       '@typescript-eslint/func-call-spacing': 2,
 
       '@typescript-eslint/indent': [`error`, 2, {

packages/eslint-config/rules/typescript.js

@@ -3,7 +3,9 @@ import typescriptEslint from '@typescript-eslint/eslint-plugin';
 // eslint-disable-next-line arca/no-default-export
 export default [
   {
-    files: [`**/*.{ts,tsx}`],
+    name: `@yarnpkg/configs/typescript`,
+
+    files: [`**/*.ts`, `**/*.cts`, `**/*.mts`, `**/*.tsx`],
 
     plugins: {
       [`@typescript-eslint`]: typescriptEslint,