test: fix custom certification tests on Windows #6450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integration tests using custom certificates have been failing for quite a while on Windows with the error `RequestError: unsuitable certificate purpose`. This error was caused by the test CA certificate used; it was not configured to be used as a CA when it was generated. The test script that generates the CA certificate has been updated to generate it correctly. The problem does not seem to be specific to Windows; I was able to reproduce it locally on macOS as well. I don't yet know why it's passing on CI for Ubuntu and macOS, but not for Windows. Perhaps some difference in the images, like the OpenSSL version (they should all be using OpenSSL v1.1.1, but I've seen reports of Windows having v3 installed as well).
Gudahtt
force-pushed
the
fix-windows-integration-tests
branch
from
cc2a01b
to
db09c24
Compare
3 tasks
|
Amazing, great find! |
merceyz
pushed a commit
that referenced
this pull request
Aug 24, 2024
## What's the problem this PR addresses? The integration tests using custom certificates have been failing for quite a while on Windows with the error `RequestError: unsuitable certificate purpose`. ## How did you fix it? This error was caused by the test CA certificate used; it was not configured to be used as a CA when it was generated. The test script that generates the CA certificate has been updated to generate it correctly. I used the same configuration options used by the test suite of the `pem` library that we are using for certificate generation: https://github.com/Dexus/pem/blob/3d71b87cec08a565ce5e73e26dd18f53b9e1fdea/test/pem.spec.js#L856 The problem does not seem to be specific to Windows; I was able to reproduce it locally on macOS as well. I don't yet know why it's passing on CI for Ubuntu and macOS, but not for Windows. Perhaps some difference in the images, like the OpenSSL version (they should all be using OpenSSL v1.1.1, but I've seen reports of Windows having v3 installed as well). ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [x] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The integration tests using custom certificates have been failing for quite a while on Windows with the error
RequestError: unsuitable certificate purpose.How did you fix it?
This error was caused by the test CA certificate used; it was not configured to be used as a CA when it was generated.
The test script that generates the CA certificate has been updated to generate it correctly. I used the same configuration options used by the test suite of the
pemlibrary that we are using for certificate generation: https://github.com/Dexus/pem/blob/3d71b87cec08a565ce5e73e26dd18f53b9e1fdea/test/pem.spec.js#L856The problem does not seem to be specific to Windows; I was able to reproduce it locally on macOS as well. I don't yet know why it's passing on CI for Ubuntu and macOS, but not for Windows. Perhaps some difference in the images, like the OpenSSL version (they should all be using OpenSSL v1.1.1, but I've seen reports of Windows having v3 installed as well).
Checklist