fix(cli): improve guessing of package names that contain a dot (#5102) (

#5135)
yarnpkg · Jan 15, 2018 · 1c3a2de · 1c3a2de
1 parent 05b4e01
commit 1c3a2de
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/__tests__/util/guess-name.js b/__tests__/util/guess-name.js
@@ -24,10 +24,25 @@ const examples = [
   'awesome-name.tar.gz',
 ];
 
+const dotExamples = [
+  'awesomename/awesome.name',
+  'awesomename/awesome.name.git',
+  'awesomename/awesome.name.tar.gz',
+  'awesomename/awesome.name.tar.bz2',
+];
+
 describe('guessName', () => {
   for (const source of examples) {
     it(`guess name of ${source}`, () => {
       expect(guessName(source)).toBe('awesome-name');
     });
   }
 });
+
+describe('guessName dot examples', () => {
+  for (const source of dotExamples) {
+    it(`guess name of ${source}`, () => {
+      expect(guessName(source)).toBe('awesome.name');
+    });
+  }
+});
diff --git a/src/util/guess-name.js b/src/util/guess-name.js
@@ -4,7 +4,7 @@ import url from 'url';
 
 function cleanup(name: string): string {
   name = name.replace(/-\d+\.\d+\.\d+/, '');
-  return name.split('.')[0];
+  return name.replace(/\.git$|\.zip$|\.tar\.gz$|\.tar\.bz2$/, '');
 }
 
 function guessNameFallback(source: string): string {