Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade-interactive does not work for Node.js above v10.2.0 #5949

Closed
negezor opened this issue Jun 7, 2018 · 9 comments
Closed

Upgrade-interactive does not work for Node.js above v10.2.0 #5949

negezor opened this issue Jun 7, 2018 · 9 comments
Assignees
@kaylie-alexa
Labels
cat-bug help wanted

Comments

@negezor
Copy link

negezor commented Jun 7, 2018

Do you want to request a feature or report a bug?

Bug

What is the current behavior?
After the packages are selected, the installation hangs in place without further output

If the current behavior is a bug, please provide the steps to reproduce.

I updated my version of Node.js from v10.0.0 to v10.4.0, this behavior started from v10.2.0
Steps:

$ yarn upgrade-interactive --latest

I select packages for updating, I press enter and all

What is the expected behavior?
Updating packages

Please mention your node.js, yarn and operating system version.
Node.js: v10.4.0
Yarn: 1.7.0
Windows: 10
@ghost ghost assigned kaylie-alexa Jun 7, 2018
@ghost ghost added the triaged label Jun 7, 2018
@gluons
Copy link

gluons commented Jul 25, 2018 •
edited
Loading

Me too. It hangs. Can't stop it with Ctrl + C.

Node: v10.7.0
Yarn: 1.7.0
OS: Windows 10

@IlCallo IlCallo mentioned this issue Nov 5, 2018
Closed
@rally25rs
Copy link
Contributor

Going to close several other issues as duplicates of this one, since this seems to be the oldest issue that reports this.

From what I can tell it's specific to Windows + Node 10.

If someone who can consistently reproduce this can help debug, it would be appreciated!

This was referenced Nov 5, 2018
Closed
Closed
@rally25rs
Copy link
Contributor

The best lead on tracking this down seems to be #6198 (comment)

pfeigl added a commit to pfeigl/yarn that referenced this issue Nov 5, 2018
@pfeigl
Fixes potential freeze on win+node10 interactive upgrades (yarnpkg#5949)
43a23b4 
There is a potential freeze when running interactive upgrades after selecting the options.
This boiles down to a problem in the `inquirer` library which is used internally to provide the possible options.
Updating `inquirer`to the latest version fixes the problem.
@pfeigl pfeigl mentioned this issue Nov 5, 2018
Merged
@pfeigl
Copy link
Contributor

pfeigl commented Nov 5, 2018

I could track this problem down to an old version of inquirer which is beeing used internally. Sent a PR to update to latest version, which seems to bring no incompatibilities but fixes the problem.

pfeigl added a commit to pfeigl/yarn that referenced this issue Nov 5, 2018
@pfeigl
Fixes potential freeze on win+node10 interactive upgrades (yarnpkg#5949)
148048d 
There is a potential freeze when running interactive upgrades after selecting the options.
This boiles down to a problem in the `inquirer` library which is used internally to provide the possible options.
Updating `inquirer`to the latest version fixes the problem.
arcanis pushed a commit that referenced this issue Nov 5, 2018
@pfeigl @arcanis
Fixes potential freeze on win+node10 interactive upgrades (#5949) (#6635
5539fa2 
)

* Fixes potential freeze on win+node10 interactive upgrades (#5949)

There is a potential freeze when running interactive upgrades after selecting the options.
This boiles down to a problem in the `inquirer` library which is used internally to provide the possible options.
Updating `inquirer`to the latest version fixes the problem.

* Update CHANGELOG.md
@heyimalex
Copy link

I know this has been merged, but just confirming that running upgrade-interactive off head works for me now!

@kallaspriit
Copy link

Had the same issue with the latest stable of 1.12.1, works with nightly 1.13.0 version.

@pfeigl
Copy link
Contributor

pfeigl commented Nov 8, 2018

1.12.3 has been released which contains this fix. I think this issue can be closed.

Thanks at the wonderful yarn team for bringing this in so super fast!

@krnlde
Copy link

krnlde commented Feb 7, 2019

@contributors: Close?

@rolbr
Copy link

rolbr commented Nov 22, 2019

Just want to confirm:

I'm on Windows 10. With Node v10.15.3 + Yarn 1.10.1 yarn upgrade-interactive would show me the table of dependencies to upgrade but would then freeze. Downloading the latest stable installer from https://yarnpkg.com/lang/en/docs/install/#windows-stable (1.19.1) fixed the issue.

Thanks! (I think this can be closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaylie-alexa kaylie-alexa

Labels
cat-bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@rally25rs @pfeigl @kallaspriit @krnlde @heyimalex @olingern @gluons @rolbr @negezor @kaylie-alexa