kpm install then kpm check reports errors

[shayne]

$ kpm install
fbkpm install v0.4.0
info Read lockfile fbkpm.lock
[1/5] ⏩  Rehydrating dependency graph...
[2/5] 📦  Fetching packages...
[3/5] ✅  Checking package compatibility...
[4/5] 🔗  Linking dependencies...
[5/5] 📃  Running install scripts...
✨  Done in 25.80s. Peak memory usage 205.83MB.

$ kpm check
fbkpm check v0.4.0
error Module not installed: node_modules/mkdirp/node_modules/minimist
error Module not installed: node_modules/escodegen/node_modules/source-map
error Module not installed: node_modules/jsbn
error Module not installed: node_modules/tweetnacl
error Module not installed: node_modules/jodid25519
error Module not installed: node_modules/ecc-jsbn

[sebmck]

Looks like there's some differences between the deduping for install and check...

[sebmck]

Looks like the difference is caused between strict and loose module installing modes.

[shayne]

Still an issue, unfortunately. I've troubleshooted but the hoisting is taking me a while to wrap my head around.

Repo steps:

• remove ~/.fbkpm
• remove ~/fbsource/fbcode/react-native/offile-files (typo, i know)
• remove react-native-github/fbkpm.lock and react-native-github/node_modules
• follow output using master fbfkpm code

 ~/Code/fbkpm/bin/kpm.js install
fbkpm install v0.4.4
info Read lockfile fbkpm.lock
[1/4] 🚚  Resolving and fetching packages...
[2/4] ✅  Checking package compatibility...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Running install scripts...
✨  Done in 22.48s. Peak memory usage 154.70MB.

$ ~/Code/fbkpm/bin/kpm.js check
fbkpm check v0.4.4
error Module not installed: node_modules/jest-runtime/node_modules/camelcase
error Module not installed: node_modules/jest-runtime/node_modules/cliui
error Module not installed: node_modules/jest-runtime/node_modules/window-size

[shayne]

Subsequent installs are successful while check continues to fail. I've looked at commands/check.js and commands/install.js and they appear to be following similar code paths. I've merged differences with no luck.

[bestander]

The deps that fail check command are dev dependencies.
If package.json does not have dev dependencies then check works correctly for react-native

[bestander]

More info, the problem is in jest-runtime and jest dependencies.
This is the minimum package.json that I can reproduce with:

{
  "name": "react-native",
  "version": "1000.0.0",
  "description": "A framework for building native apps using React",
  "dependencies": {
    "jest": "^13.0.0",
    "jest-runtime": "^13.0.0"
  }
}

Just removing jest-runtime from the above or the whole react-native package.json makes check great again.

I'll investigate more tomorrow

[bestander]

Last info for today, there is a bug in hoisting algorithm for the above package.json:

jest-cli@13.0.0 -> yargs@4.7.1 -> camelcase@3.0.0
jest-runtime@13.0.0 -> yargs@4.7.1 -> camelcase@3.0.0
yargs@3.10.0 -> camelcase@1.0.2

This installs jest-runtime/node_modules/yargs but not jest-runtime/node_modules/camelcase.
However jest-cli/node_modules/yargs and jest-cli/node_modules/camelcase do get installed

[bestander]

Added #89 with an e2e test.

[bestander]

@shayne, there is a way around this bug for now.
Just remove jest-runtime from dev dependencies, it will get installed anyway because jest depends on it while check will succeed.