fixes #2406 - don't create tag for preminor version change in master branch #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel15
reviewed
Jan 12, 2017
| yarn version --new-version preminor --no-git-tag-version | ||
| NEW_VERSION=$(node -p -e "require('./package.json').version") | ||
| git commit -a -m "$NEW_VERSION" | ||
| git push origin master |
There was a problem hiding this comment.
Why did you remove the --follow-tags flag?
There was a problem hiding this comment.
I stopped tagging master branch so that GitHub does not consider it as a new release.
So no reason to send new tags to origin
|
@Daniel15, ping, was my explanation satisfactory? |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New tags trigger CI to make GitHub releases, there is no need for us to tag master branch with preminor version every time the branch is cut