Add -loader
suffix in webpack, closes #2410
#2447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundled builds were not being built correctly..
Example: https://github.com/yarnpkg/yarn/releases/download/v0.19.0/yarn-0.19.0.js
Issue: #2410
tl;dr
Just add
-loader
suffix to loaders in to scripts/build-webpack.js. ezpzDetails
Previously, packages named with
-loader
suffix could be specified as loaders within Webpack without requiring the suffix to be named explicitly. Webpack 2.1.0-beta.26 no longer looks for-loader
suffix automatically, and packages have to therefore be named explicitly or-loader
can be added toresolveLoader.moduleExtensions
.See: https://github.com/webpack/webpack/releases/tag/v2.1.0-beta.26
This PR explicitly adds
-loader
suffix, and now bundles are correctly built.Before
After