Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lockfileOutdated description $ to allow easier copy/paste #2516

Merged
merged 2 commits into from
Jan 26, 2017
Merged

Remove lockfileOutdated description $ to allow easier copy/paste #2516

merged 2 commits into from
Jan 26, 2017

Conversation

grant
Copy link
Contributor

@grant grant commented Jan 20, 2017

Summary
Remove $ to allow easier copy/paste

Test plan

  • Run yarn outdated with an outdated lockfile.

@xaka
Copy link

xaka commented Jan 22, 2017

@grant was about to send similar PR and found yours, good catch! i also find it too noisy to prepend commands with $ ; there is another line (https://github.com/yarnpkg/yarn/blob/master/src/reporters/lang/en.js#L237) with same "issue", i believe it makes sense to clean everything up in single PR?

@grant
Copy link
Contributor Author

grant commented Jan 22, 2017

@xaka Thanks. Makes sense. LMK if there's anything else.

@bestander bestander merged commit a1c13e9 into yarnpkg:master Jan 26, 2017
ConAntonakos pushed a commit to ConAntonakos/yarn that referenced this pull request Jan 30, 2017
…arnpkg#2516)

* Remove `$` to allow easier copy/paste

* Remove more dollar signs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants