fixes binary links issue #3545
Merged
fixes binary links issue #3545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3535 and #3332
Summary
Package-linker had a save() phase done after all modules are copied from cache into node_modules.
In there it would create symlinks to topmost dependencies.
Turns out this became obsolete after we started creating symlinks for all nonconflicting packges.
So save() function would sometimes overwrite correct symlinks with the ones taken from deeper dependency tree.
Test plan
Passes test in https://github.com/cmoesel/eslint-8547