feat(cli): group by license in licenses list (#5074) #5110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change will increase the build size from 10.39 MB to 10.39 MB, an increase of 1.01 KB (0%)
|
|
Previous output was of the form: New output with this PR is of the form: @Haroenv does this fit your intent behind #5074 ? I also added you as a requested reviewer since it was your feature request 😉 |
|
This definitely makes it more easy to grasp! I was originally more thinking of a simple list of the licenses, but this is definitely a great UI too |
Haroenv
reviewed
Dec 19, 2017
|
It changes the output so if some other tool was parsing that then this would break it. I believe the JSON output is unchanged though, which is hopefully what you'd be using in that case. |
Haroenv
approved these changes
Dec 20, 2017
arcanis
approved these changes
Jan 15, 2018
|
Thanks! This is a great idea! |
agoldis
added a commit
to agoldis/yarn
that referenced
this pull request
Feb 2, 2018
…readdir_files * upstream/master: (34 commits) feat(upgrade, add): Separately log added/upgraded dependencies (yarnpkg#5227) feat(publish): Publish command uses publishConfig.access in package.json (yarnpkg#5290) fix(CLI): Use process exit instead of exitCode for node < 4 (yarnpkg#5291) feat(cli): error on missing workspace directory (yarnpkg#5206) (yarnpkg#5222) feat: better error when package is not found (yarnpkg#5213) Allow scoped package as alias source (yarnpkg#5229) fix(cli): Use correct directory for upgrade-interactive (yarnpkg#5272) nohoist baseline implementation (yarnpkg#4979) 1.4.1 1.4.0 Show current version, when new version is not supplied on "yarn publish" (yarnpkg#4947) fix(install): use node-gyp from homebrew npm (yarnpkg#4994) Fix transient symlinks overriding direct ones v2 (yarnpkg#5016) fix(auth): Fixes authentication conditions and logic with registries (yarnpkg#5216) chore(package): move devDeps to appropriate place (yarnpkg#5166) fix(resolution) Eliminate "missing peerDep" warning when dep exists at root level. (yarnpkg#5088) fix(cli): improve guessing of package names that contain a dot (yarnpkg#5102) (yarnpkg#5135) feat(cli): include notice with license when generating disclaimer (yarnpkg#5072) (yarnpkg#5111) feat(cli): group by license in licenses list (yarnpkg#5074) (yarnpkg#5110) feat(cli): improve error message when file resolver can't find file (yarnpkg#5134) (yarnpkg#5145) ...
commonquail
added a commit
to commonquail/completionist
that referenced
this pull request
Mar 28, 2018
yarnpkg/yarn#5110 changed the format of "yarn licenses list" to deduplicate licenses, with no way to keep the old format. Rebuild NOTICE file to match the new output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Group packages by license when running
yarn license listas requested in #5074.Test plan
Run
yarn license listin an existing package and observe that packages are grouped by license.