Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency normalize-url to ^2.0.0 #5183

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 8, 2018

This Pull Request updates dependency normalize-url from ^1.9.1 to ^2.0.0

Commits

v2.0.0

v2.0.1

  • 01fc811 Avoid appending a 'null' string as query params (#​54)
  • f4df606 2.0.1

This PR has been generated by Renovate Bot.

@buildsize
Copy link

buildsize bot commented Jan 8, 2018

This change will increase the build size from 10.49 MB to 10.5 MB, an increase of 8.09 KB (0%)

File name Previous Size New Size Change
yarn-[version].noarch.rpm 909.34 KB 910.04 KB 719 bytes (0%)
yarn-[version].js 3.95 MB 3.96 MB 2.97 KB (0%)
yarn-legacy-[version].js 4.1 MB 4.1 MB 2.97 KB (0%)
yarn-v[version].tar.gz 914.8 KB 915.66 KB 882 bytes (0%)
yarn_[version]all.deb 675.21 KB 675.79 KB 596 bytes (0%)

@rarkins
Copy link
Contributor

rarkins commented Jan 9, 2018

Possibly an ephemeral failure?

Summary of all failing tests
FAIL __tests__\package-resolver.js (99.946s)
  ● resolve git+https://github.com/ocaml/ocaml.git#4.02.3
    Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
      
      at node_modules/jest-jasmine2/build/queue_runner.js:64:21
      at Timer.listOnTimeout (timers.js:92:15)

The only suspicious thing was that it's node.js 4

@Simek
Copy link
Contributor

Simek commented Jan 10, 2018

I was getting random timeouts when I was reverting those test to live so timeout has beed extended by 30s (#5165) . Same situation as here happend in #5184, but on Node 8. Those timeout issues are really weird and inconsistent.

Max resolve time seems peak across few dependencies bump PRs was around 130s. As a temporal solution we could extend Jasmine timeout even more, but this will be only a workaround.

Also maybe changing OCaml to other smaller repo i.e. Yarn/Lodash will be better approach?

@renovate renovate bot force-pushed the renovate/normalize-url-2.x branch 8 times, most recently from f93b7c3 to c3a2ce2 Compare February 23, 2018 14:42
@renovate renovate bot force-pushed the renovate/normalize-url-2.x branch 2 times, most recently from e6c084a to 6e48a12 Compare February 27, 2018 17:38
@renovate renovate bot force-pushed the renovate/normalize-url-2.x branch from 6e48a12 to 78110d1 Compare February 27, 2018 17:58
@arcanis arcanis merged commit 19dec15 into master Mar 1, 2018
@renovate renovate bot deleted the renovate/normalize-url-2.x branch March 1, 2018 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants