Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Add basic auth support for pathed registries #5322

Merged
merged 1 commit into from
Oct 6, 2018
Merged

feat(auth): Add basic auth support for pathed registries #5322

merged 1 commit into from
Oct 6, 2018

Conversation

KidkArolis
Copy link
Contributor

Summary

Builds on top of #5216.

Adds support for using Basic auth like so:

@scope:registry=https://artifactory.example.com/api/npm/registry/
//artifactory.example.com/api/npm/registry/:username=uuuu
//artifactory.example.com/api/npm/registry/:_password=pppp
//artifactory.example.com/api/packages/username=uuuu
//artifactory.example.com/api/packages/:_password=pppp

As pointed out in #5216 (comment).

Test plan

Test gen ftw!

@KidkArolis KidkArolis mentioned this pull request Feb 5, 2018
Merged
@KidkArolis KidkArolis force-pushed the pathed-registries-with-basic-auth branch from 021b84d to 6e5a3b5 Compare February 13, 2018 21:59
@KidkArolis
Copy link
Contributor Author

Updated PR to fix linting issues.

@buildsize
Copy link

buildsize bot commented Feb 13, 2018 •
edited
Loading

File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.09 MB 1.09 MB -53 bytes (0%)
yarn-[version].js 4.26 MB 4.26 MB 16 bytes (0%)
yarn-legacy-[version].js 4.44 MB 4.44 MB 16 bytes (0%)
yarn-v[version].tar.gz 1.1 MB 1.1 MB 1.88 KB (0%)
yarn_[version]all.deb 803.52 KB 803.82 KB 314 bytes (0%)

@KidkArolis
Copy link
Contributor Author

CI timed out, don't think it's the fault of the change in this PR

@KidkArolis KidkArolis mentioned this pull request Aug 1, 2018
Closed
@KidkArolis
Copy link
Contributor Author

Should we merge or cancel?

@Gudahtt Gudahtt force-pushed the pathed-registries-with-basic-auth branch from 6e5a3b5 to 241424c Compare October 3, 2018 18:02
Gudahtt
Gudahtt requested changes Oct 3, 2018
View reviewed changes
__tests__/registries/npm-registry.js Outdated
@@ -6,6 +6,11 @@ import NpmRegistry from '../../src/registries/npm-registry.js';
import {BufferReporter} from '../../src/reporters/index.js';
import homeDir, {home} from '../../src/util/user-home-dir.js';

function basicAuth(username, password): string {
const pw = new Buffer(String(password), 'base64').toString();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buffer.from should be used on these two lines instead of the Buffer constructor (which has been deprecated).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, should I squash the commits?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

You can squash this if you want, but it doesn't matter, We typically use squash merging, so Github will ensure it's a single commit either way.

@Gudahtt
Copy link
Member

Gudahtt commented Oct 3, 2018

I'd like to get this merged. I've just rebased this to trigger CI to run again.

Gudahtt
Gudahtt requested changes Oct 3, 2018
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently adopted a new changelog process. You should add an entry for this change to CHANGELOG.md, under the heading Master.

This slipped my mind until just now; sorry for not mentioning this earlier!

@KidkArolis KidkArolis force-pushed the pathed-registries-with-basic-auth branch from d3e7751 to 16abc53 Compare October 5, 2018 22:07
@KidkArolis
Copy link
Contributor Author

Rebased, squashed and updated changelog.

@Gudahtt Gudahtt merged commit 9bb2cfb into yarnpkg:master Oct 6, 2018
@Gudahtt
Copy link
Member

Gudahtt commented Oct 6, 2018

Thanks!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Nov 22, 2018
@kleink
yarn: Update to 1.12.3.
b5e8a0a 
Changelog tracks back up to 1.12.0 only.

## 1.12.3

**Important:** This release contains a cache bump. It will cause the very first install following the upgrade to take slightly more time, especially if you don't use the [Offline Mirror](https://yarnpkg.com/blog/2016/11/24/offline-mirror/) feature. After that everything will be back to normal.

- Fixes an issue with `yarn audit` when using workspaces

  [6625](yarnpkg/yarn#6639) - [**Jeff Valore**](https://twitter.com/codingwithspike)

- Uses `NODE_OPTIONS` to instruct Node to load the PnP hook, instead of raw CLI arguments

  **Caveat:** This change might cause issues for PnP users having a space inside their cwd (cf [nodejs/node24065](nodejs/node#24065))

  [6479](yarnpkg/yarn#6629) - [**Maël Nison**](https://twitter.com/arcanis)

- Fixes Gulp when used with Plug'n'Play

  [6623](yarnpkg/yarn#6623) - [**Maël Nison**](https://twitter.com/arcanis)

- Fixes an issue with `yarn audit` when the root package was missing a name

  [6611](yarnpkg/yarn#6611) - [**Jack Zhao**](https://github.com/bugzpodder)

- Fixes an issue with `yarn audit` when a package was depending on an empty range

  [6611](yarnpkg/yarn#6611) - [**Jack Zhao**](https://github.com/bugzpodder)

- Fixes an issue with how symlinks are setup into the cache on Windows

  [6621](yarnpkg/yarn#6621) - [**Yoad Snapir**](https://github.com/yoadsn)

- Upgrades `inquirer`, fixing `upgrade-interactive` for users using both Node 10 and Windows

  [6635](yarnpkg/yarn#6635) - [**Philipp Feigl**](https://github.com/pfeigl)

- Exposes the path to the PnP file using `require.resolve('pnpapi')`

  [6643](yarnpkg/yarn#6643) - [**Maël Nison**](https://twitter.com/arcanis)

## 1.12.2

This release doesn't actually exists and was caused by a quirk in our systems.

## 1.12.1

- Ensures the engine check is ran before showing the UI for `upgrade-interactive`

  [6536](yarnpkg/yarn#6536) - [**Orta Therox**](https://github.com/orta)

- Restores Node v4 support by downgrading `cli-table3`

  [6535](yarnpkg/yarn#6535) - [**Mark Stacey**](https://github.com/Gudahtt)

- Prevents infinite loop when parsing corrupted lockfiles with unterminated strings

  [4965](yarnpkg/yarn#4965) - [**Ryan Hendrickson**](https://github.com/rhendric)

- Environment variables now have to **start** with `YARN_` (instead of just contain it) to be considered

  [6518](yarnpkg/yarn#6518) - [**Michael Gmelin**](https://blog.grem.de)

- Fixes the `extensions` option when used by `resolveRequest`

  [6479](yarnpkg/yarn#6479) - [**Maël Nison**](https://twitter.com/arcanis)

- Fixes handling of empty string entries for `bin` in package.json

  [6515](yarnpkg/yarn#6515) - [**Ryan Burrows**](https://github.com/rhburrows)

- Adds support for basic auth for registries with paths, such as artifactory

  [5322](yarnpkg/yarn#5322) - [**Karolis Narkevicius**](https://twitter.com/KidkArolis)

- Adds 2FA (Two Factor Authentication) support to publish & alike

  [6555](yarnpkg/yarn#6555) - [**Krzysztof Zbudniewek**](https://github.com/neonowy)

- Fixes how the `files` property is interpreted to bring it in line with npm

  [6562](yarnpkg/yarn#6562) - [**Bertrand Marron**](https://github.com/tusbar)

- Fixes Yarn invocations on Darwin when the `yarn` binary was symlinked

  [6568](yarnpkg/yarn#6568) - [**Hidde Boomsma**](https://github.com/hboomsma)

- Fixes `require.resolve` when used together with the `paths` option

  [6565](yarnpkg/yarn#6565) - [**Maël Nison**](https://twitter.com/arcanis)

## 1.12.0

- Adds initial support for PnP on Windows

  [6447](yarnpkg/yarn#6447) - [**John-David Dalton**](https://twitter.com/jdalton)

- Adds `yarn audit` (and the `--audit` flag for all installs)

  [6409](yarnpkg/yarn#6409) - [**Jeff Valore**](https://github.com/rally25rs)

- Adds a special logic to PnP for ESLint compatibility (temporary, until [eslint/eslint10125](eslint/eslint#10125) is fixed)

  [6449](yarnpkg/yarn#6449) - [**Maël Nison**](https://twitter.com/arcanis)

- Makes the PnP hook inject a `process.versions.pnp` variable when setup (equals to `VERSIONS.std`)

  [6464](yarnpkg/yarn#6464) - [**Maël Nison**](https://twitter.com/arcanis)

- Disables by default (configurable) the automatic migration of the `integrity` field. **It will be re-enabled in 2.0.**

  [6465](yarnpkg/yarn#6465) - [**Maël Nison**](https://twitter.com/arcanis)

- Fixes the display name of the faulty package when the NPM registry returns corrupted data

  [6455](yarnpkg/yarn#6455) - [**Grey Baker**](https://github.com/greysteil)

- Prevents crashes when running `yarn outdated` and the NPM registry forgets to return the `latest` tag

  [6454](yarnpkg/yarn#6454) - [**mad-mike**](https://github.com/mad-mike)

- Fixes `yarn run` when used together with workspaces and PnP

  [6444](yarnpkg/yarn#6444) - [**Maël Nison**](https://twitter.com/arcanis)

- Fixes an edge case when peer dependencies were resolved multiple levels deep (`webpack-dev-server`)

  [6443](yarnpkg/yarn#6443) - [**Maël Nison**](https://twitter.com/arcanis)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KidkArolis @Gudahtt