-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add self update #6736
Add self update #6736
Conversation
|
We have |
@AlexWayfer good point, I've put it back as |
I believe this feature conflicts in spirit with #6673, which is already in master |
@arcanis I see. Many ppl still refer to #1139 to try and find the way to properly upgrade yarn as the docs still mention it. Do you think there's room for both commands? Maybe self-upgrade is worth keeping for the clarity of its name. Maybe even as an alias to Otherwise, we should work on making the community aware of this by linking to it on the current |
src/cli/commands/self-update.js
Outdated
isInteractive: true, | ||
}); | ||
} else { | ||
reporter.info('could not find command for instalation method'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installation
Summary
closes: #1139
Putting back
yarn self-update
as we now have a way of knowing which installation method was used and how to properly update.Test plan
As this is my first contribution to this project I'd really appreciate some feedback before going into implementing tests. I'll add them asap.
I'm looking forward for some feedback on this! Thanks!