Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self update #6736

Closed
wants to merge 5 commits into from
Closed

Conversation

rafael-vitor
Copy link

Summary

closes: #1139
Putting back yarn self-update as we now have a way of knowing which installation method was used and how to properly update.

Test plan

As this is my first contribution to this project I'd really appreciate some feedback before going into implementing tests. I'll add them asap.

I'm looking forward for some feedback on this! Thanks!

@buildsize
Copy link

buildsize bot commented Nov 29, 2018

File name Previous Size New Size Change
yarn-[version].noarch.rpm 1.1 MB 1.11 MB 2.35 KB (0%)
yarn-[version].js 4.47 MB 4.47 MB 3.05 KB (0%)
yarn-legacy-[version].js 4.66 MB 4.66 MB 3.05 KB (0%)
yarn-v[version].tar.gz 1.12 MB 1.12 MB 215 bytes (0%)
yarn_[version]all.deb 814.61 KB 815.02 KB 420 bytes (0%)

@AlexWayfer
Copy link

We have upgrade command for packages, not update, and probably should have self-upgrade instead of self-update. Also, in apt there are update for repositories refresh and upgrade for packages update.

@rafael-vitor
Copy link
Author

@AlexWayfer good point, I've put it back as self-update because thats how its still described on the docs: https://yarnpkg.com/lang/en/docs/cli/self-update/ and it was like that until it got removed: 6c41fee.
If its consensus that it should be upgrade I'll happily change it. Maybe the older contributors can help shed some light onto why update was used.

@arcanis
Copy link
Member

arcanis commented Nov 29, 2018

I believe this feature conflicts in spirit with #6673, which is already in master

@rafael-vitor
Copy link
Author

@arcanis I see. Many ppl still refer to #1139 to try and find the way to properly upgrade yarn as the docs still mention it.

Do you think there's room for both commands? Maybe self-upgrade is worth keeping for the clarity of its name. Maybe even as an alias to yarn policies set-version.

Otherwise, we should work on making the community aware of this by linking to it on the current self-update doc and/or removing it eventually.

isInteractive: true,
});
} else {
reporter.info('could not find command for instalation method');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yarn self-update should update using the same installation method originally used
4 participants