Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Yarn invocations on Darwin when symlinked #6930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes Yarn invocations on Darwin when symlinked #6930

wants to merge 1 commit into from

Conversation

serverwentdown
Copy link

@serverwentdown serverwentdown commented Jan 16, 2019 •
edited
Loading

#6568 had an attempt to fix this issue, however it does not solve the problem (works only on symlinked bin directories)

Summary

Test plan

@serverwentdown
Fixes Yarn invocations on Darwin when symlinked
fe57546 
yarnpkg#6568 had an attempt to fix this issue, however it does not work.
@serverwentdown serverwentdown mentioned this pull request Jan 17, 2019
Merged
arcanis
arcanis requested changes Jan 23, 2019
View reviewed changes
bin/yarn Show resolved Hide resolved
@serverwentdown
Copy link
Author

serverwentdown commented Feb 5, 2019 •
edited
Loading

Example scenario that doesn't work in macOS right now:

Yarn in /usr/local/share/yarn
Symlink in /usr/local/bin/yarn -> ../share/yarn/bin/yarn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcanis arcanis Awaiting requested review from arcanis

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serverwentdown @arcanis