Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3/3 header changes][http] Emit metrics for new headers handling behaviour. Hide actual changes under feature flag. #2275

Open
wants to merge 1 commit into
base: emit-metrics-for-new-behavior-step-1
Choose a base branch
from

Emit metrics for reserved headers in HTTP. Hide actual changes under …

0c05bc3
Select commit
Loading
Failed to load commit list.
Open

[3/3 header changes][http] Emit metrics for new headers handling behaviour. Hide actual changes under feature flag. #2275

Emit metrics for reserved headers in HTTP. Hide actual changes under …
0c05bc3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 10, 2024 in 0s

85.29% (target 80.00%)

View this Pull Request on Codecov

85.29% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.29%. Comparing base (f7b3c8e) to head (0c05bc3).

Files Patch % Lines
transport/http/handler.go 84.61% 1 Missing and 1 partial ⚠️
transport/http/outbound.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           emit-metrics-for-new-behavior-step-1    #2275      +/-   ##
========================================================================
- Coverage                                 85.33%   85.29%   -0.05%     
========================================================================
  Files                                       271      271              
  Lines                                     15624    15648      +24     
========================================================================
+ Hits                                      13333    13347      +14     
- Misses                                     1872     1877       +5     
- Partials                                    419      424       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.