Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is youcomplete me doesn't show suggestions with javacomplete2 but manually invoking suggestions works #1816

Closed
purpleP opened this issue Dec 6, 2015 · 2 comments

Comments

@purpleP
Copy link

purpleP commented Dec 6, 2015

I've tried to add
let g:ycm_semantic_triggers = {'java': 're!.'}
to vimrc
and to execute this command in vim.
In both cases autocompletion haven't been triggered when typing some class of the field, but I could've call autocomplete menu by pressing ctrl-x-o.

Is that expected behaviour?

@puremourning
Copy link
Member

IIRC @Valloric has said that "semantic" (in this case omnifunc) completion without a trigger is out of scope of YCM. From memory, others have tried to use the regex you include without success. THere is some quite lengthy discussion about the foibles of the omnifunc completer and javacomplete2 on this issue: #1779.

@micbou
Copy link
Collaborator

micbou commented Aug 13, 2016

Duplicate of #1322.

@micbou micbou closed this as completed Aug 13, 2016
zzbot added a commit that referenced this issue Jul 3, 2017
[READY] Reset the start column in omnifunc completer

# PR Prelude

Thank you for working on YCM! :)

**Please complete these steps and check these boxes (by putting an `x` inside
the brackets) _before_ filing your PR:**

- [X] I have read and understood YCM's [CONTRIBUTING][cont] document.
- [X] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
- [X] I have included tests for the changes in my PR. If not, I have included a
  rationale for why I haven't.
- [X] **I understand my PR may be closed if it becomes obvious I didn't
  actually perform all of these steps.**

# Why this change is necessary and useful

A number of issues have been raised over the years where YCM doesn't interact great with the user's omnifunc. This is commonly because we ignore the omnifunc's `findstart` response, and use our own implementation (`base.CompletionStartColumn`).

In combination with ycm-core/ycmd#681 this change uses the omnifunc's start column for completions and fixes ycm-core/ycmd#671 and others, such as:

- #1322 probably (not yet tested)
- #1957
- #1816

Note: This is just an initial test for sharing the code to gauge reaction. Not fully tested yet.

[cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md
[code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2489)
<!-- Reviewable:end -->
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants