Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Update autocommands examples in documentation #2635

Merged
merged 1 commit into from
May 5, 2017

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented May 5, 2017

I am not aware of a Vim option to not switch to the location list (or quickfix) window when calling lopen (respectively copen) so I think it's a good idea to give an example in the docs on how to achieve this using the YcmLocationOpened and YcmQuickFixOpened autocommands.

Also, the execute calls are not needed.


This change is Reviewable

@micbou micbou force-pushed the update-autocommand-examples branch from 28c6984 to f7db6a1 Compare May 5, 2017 19:36
@micbou
Copy link
Collaborator Author

micbou commented May 5, 2017

Removed it from the YcmQuickFixOpened example. This autocommand is triggered when jumping and it's not particularly useful to switch back to the current window in that case.


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov-io
Copy link

codecov-io commented May 5, 2017

Codecov Report

Merging #2635 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2635   +/-   ##
=======================================
  Coverage   87.67%   87.67%           
=======================================
  Files          19       19           
  Lines        1947     1947           
=======================================
  Hits         1707     1707           
  Misses        240      240

@Valloric
Copy link
Member

Valloric commented May 5, 2017

:lgtm:

Thanks for the PR!

@vheon
Copy link
Contributor

vheon commented May 5, 2017

:lgtm: @homu r=Valloric


Reviewed 1 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@micbou
Copy link
Collaborator Author

micbou commented May 5, 2017

Is homu not working?

@homu r+


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@homu
Copy link
Contributor

homu commented May 5, 2017

📌 Commit f7db6a1 has been approved by micbou

@homu
Copy link
Contributor

homu commented May 5, 2017

⌛ Testing commit f7db6a1 with merge 5a806dc...

homu added a commit that referenced this pull request May 5, 2017
[READY] Update autocommands examples in documentation

I am not aware of a Vim option to not switch to the location list (or quickfix) window when calling `lopen` (respectively `copen`) so I think it's a good idea to give an example in the docs on how to achieve this using the `YcmLocationOpened` and `YcmQuickFixOpened` autocommands.

Also, the `execute` calls are not needed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2635)
<!-- Reviewable:end -->
@homu
Copy link
Contributor

homu commented May 5, 2017

☀️ Test successful - status

@homu homu merged commit f7db6a1 into ycm-core:master May 5, 2017
@micbou micbou deleted the update-autocommand-examples branch May 6, 2017 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants