-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Update autocommands examples in documentation #2635
Conversation
28c6984
to
f7db6a1
Compare
Removed it from the Reviewed 2 of 2 files at r1. Comments from Reviewable |
Codecov Report
@@ Coverage Diff @@
## master #2635 +/- ##
=======================================
Coverage 87.67% 87.67%
=======================================
Files 19 19
Lines 1947 1947
=======================================
Hits 1707 1707
Misses 240 240 |
@homu r=Valloric Reviewed 1 of 2 files at r1. Comments from Reviewable |
Is homu not working? @homu r+ Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
📌 Commit f7db6a1 has been approved by |
[READY] Update autocommands examples in documentation I am not aware of a Vim option to not switch to the location list (or quickfix) window when calling `lopen` (respectively `copen`) so I think it's a good idea to give an example in the docs on how to achieve this using the `YcmLocationOpened` and `YcmQuickFixOpened` autocommands. Also, the `execute` calls are not needed. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2635) <!-- Reviewable:end -->
☀️ Test successful - status |
I am not aware of a Vim option to not switch to the location list (or quickfix) window when calling
lopen
(respectivelycopen
) so I think it's a good idea to give an example in the docs on how to achieve this using theYcmLocationOpened
andYcmQuickFixOpened
autocommands.Also, the
execute
calls are not needed.This change is