Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Completely remove g:ycm_allow_changing_updatetime option #2656

Merged

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented May 19, 2017

Forgot to remove the g:ycm_allow_changing_updatetime option from plugin/youcompleteme.vim in PR #2636.


This change is Reviewable

@bstaletic
Copy link
Collaborator

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@Valloric
Copy link
Member

:lgtm:

Thanks for the PR!

@zzbot r=bstaletic

@zzbot
Copy link
Contributor

zzbot commented May 19, 2017

📌 Commit 07c04f0 has been approved by bstaletic

@zzbot
Copy link
Contributor

zzbot commented May 19, 2017

⌛ Testing commit 07c04f0 with merge acf9ede...

zzbot added a commit that referenced this pull request May 19, 2017
… r=bstaletic

[READY] Completely remove g:ycm_allow_changing_updatetime option

Forgot to remove the `g:ycm_allow_changing_updatetime` option from `plugin/youcompleteme.vim` in PR #2636.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2656)
<!-- Reviewable:end -->
@zzbot
Copy link
Contributor

zzbot commented May 19, 2017

☀️ Test successful - status-travis
Approved by: bstaletic
Pushing acf9ede to master...

@zzbot zzbot merged commit 07c04f0 into ycm-core:master May 19, 2017
@codecov-io
Copy link

codecov-io commented May 19, 2017

Codecov Report

Merging #2656 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2656   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files          19       19           
  Lines        1946     1946           
=======================================
  Hits         1722     1722           
  Misses        224      224

@micbou micbou deleted the remove-allow-changing-updatetime-option branch June 25, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants