-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[READY] Do not disable omnifunc when filetype completion is disabled #2978
[READY] Do not disable omnifunc when filetype completion is disabled #2978
Conversation
2b0c34f
to
ad13b62
Compare
Codecov Report
@@ Coverage Diff @@
## master #2978 +/- ##
==========================================
+ Coverage 92.6% 93.34% +0.73%
==========================================
Files 21 21
Lines 2070 2359 +289
==========================================
+ Hits 1917 2202 +285
- Misses 153 157 +4 |
ad13b62
to
cbf5430
Compare
Reviewed 3 of 3 files at r1. Comments from Reviewable |
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed. python/ycm/omni_completer.py, line 67 at r1 (raw file):
This looks like the same logic from youcompleteme.py ? Can we avoid duplicating it ? Comments from Reviewable |
Allow users to still trigger Vim's omnifunc through C-Space when the g:ycm_filetype_specific_completion_to_disable option is set for the current filetype.
cbf5430
to
e96ef7c
Compare
Reviewed 1 of 3 files at r1, 3 of 3 files at r2. python/ycm/omni_completer.py, line 67 at r1 (raw file): Previously, puremourning (Ben Jackson) wrote…
Added a new function Comments from Reviewable |
@zzbot r+ Reviewed 1 of 3 files at r1, 3 of 3 files at r2. Comments from Reviewable |
📌 Commit e96ef7c has been approved by |
…ble, r=puremourning [READY] Do not disable omnifunc when filetype completion is disabled Prior to PR #2657, it was possible to trigger Vim's omnifunc with `<C-Space>` even if semantic completion was disabled for the current filetype through the `g:ycm_filetype_specific_completion_to_disable` option. It worked because `<C-Space>` was mapped to `<C-X><C-O><C-P>`, which are the keys to trigger the omnifunc. PR #2657 changed that by making `<C-Space>` directly call the `SendCompletionRequest` function with `force_semantic` sets to `True`. This change was necessary to get fuzzy matching with the omnifunc (see issue #961) but broke the `<C-Space>` behavior when filetype completion is disabled. This PR restores that behavior. Fixes #2950. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2978) <!-- Reviewable:end -->
☀️ Test successful - status-appveyor, status-travis |
Prior to PR #2657, it was possible to trigger Vim's omnifunc with
<C-Space>
even if semantic completion was disabled for the current filetype through theg:ycm_filetype_specific_completion_to_disable
option. It worked because<C-Space>
was mapped to<C-X><C-O><C-P>
, which are the keys to trigger the omnifunc. PR #2657 changed that by making<C-Space>
directly call theSendCompletionRequest
function withforce_semantic
sets toTrue
. This change was necessary to get fuzzy matching with the omnifunc (see issue #961) but broke the<C-Space>
behavior when filetype completion is disabled. This PR restores that behavior.Fixes #2950.
This change is