Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Update all actions #4175

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Aug 19, 2023

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

Because github is complaining about the age of actions.


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 19, 2023

Codecov Report

Merging #4175 (2e8b209) into master (7684b6c) will decrease coverage by 2.48%.
Report is 238 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4175      +/-   ##
==========================================
- Coverage   91.30%   88.82%   -2.48%     
==========================================
  Files          27       34       +7     
  Lines        3714     4395     +681     
==========================================
+ Hits         3391     3904     +513     
- Misses        323      491     +168     

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

@bstaletic bstaletic added the Ship It! Manual override to merge a PR by maintainer label Aug 19, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2023

Thanks for sending a PR!

@puremourning puremourning merged commit 4f1dcf4 into ycm-core:master Aug 19, 2023
8 of 12 checks passed
@bstaletic bstaletic deleted the new_actions branch August 19, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants